This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
Update 105-update-root-area-and-iteration-path-field.sql #2313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on [this discussion](https://chat.openshift.io/developers/pl/6m4cojtiotdoueqot8uww5ybpe) we first remove the unique name index on the `iterations` and `areas` table before we modify the data. In a previous attempt (#2312) I haven't moved the removal of the index enough up. This should fix the migration issue that was visible here: openshiftio/saas-openshiftio#1082
Ike Plugins (test-keeper)Thank you @kwk for this contribution!
It appears that no tests have been added or updated in this PR. Automated tests give us confidence in shipping reliable software. Please add some as part of this change. If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command For more information please head over to official documentation. You can find there how to configure the plugin. |
aslakknutsen
approved these changes
Oct 10, 2018
|
/ok-without-tests |
kwk
added a commit
to openshiftio/saas-openshiftio
that referenced
this pull request
Oct 10, 2018
# About
This description was generated using this script:
```sh
#!/bin/bash
set -e
GHORG=${GHORG:-fabric8-services}
GHREPO=${GHREPO:-fabric8-wit}
cat <<EOF
# About
This description was generated using this script:
\`\`\`sh
`cat $0`
\`\`\`
Invoked as:
`echo GHORG=${GHORG} GHREPO=${GHREPO} $(basename $0) ${@:1}`
# Changes
EOF
git log \
--pretty="%n**Commit:** https://github.com/${GHORG}/${GHREPO}/commit/%H%n**Author:** %an (%ae)%n**Date:** %aI%n%n%s%n%n%b%n%n----%n" \
--reverse ${@:1} \
| sed -E "s/([\s|\(| ])#([0-9]+)/\1${GHORG}\/${GHREPO}#\2/g"
```
Invoked as:
GHORG=fabric8-services GHREPO=fabric8-wit git-log-pr.sh 1371e8243fb9f68775a50a8eca738193db706164..87bf305c5d73a9cf4df5f37172aaf19d9e7034ea
# Changes
**Commit:** fabric8-services/fabric8-wit@87bf305
**Author:** Konrad Kleine (193408+kwk@users.noreply.github.com)
**Date:** 2018-10-10T13:12:53+02:00
Update 105-update-root-area-and-iteration-path-field.sql (fabric8-services/fabric8-wit#2313)
Based on [this discussion](https://chat.openshift.io/developers/pl/6m4cojtiotdoueqot8uww5ybpe) we first remove the unique name index on the `iterations` and `areas` table before we modify the data.
In a previous attempt (fabric8-services/fabric8-wit#2312) I haven't moved the removal of the index enough up.
This should fix the migration issue that was visible here: #1082
----
Codecov Report
@@ Coverage Diff @@
## master #2313 +/- ##
======================================
Coverage 70.1% 70.1%
======================================
Files 174 174
Lines 16796 16796
======================================
Hits 11775 11775
Misses 3888 3888
Partials 1133 1133Continue to review full report at Codecov.
|
kwk
added a commit
to openshiftio/saas-openshiftio
that referenced
this pull request
Oct 10, 2018
# Changes **Commit:** fabric8-services/fabric8-wit@87bf305 **Author:** Konrad Kleine (193408+kwk@users.noreply.github.com) **Date:** 2018-10-10T13:12:53+02:00 Update 105-update-root-area-and-iteration-path-field.sql (fabric8-services/fabric8-wit#2313) Based on [this discussion](https://chat.openshift.io/developers/pl/6m4cojtiotdoueqot8uww5ybpe) we first remove the unique name index on the `iterations` and `areas` table before we modify the data. In a previous attempt (fabric8-services/fabric8-wit#2312) I haven't moved the removal of the index enough up. This should fix the migration issue that was visible here: #1082 ----
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this discussion we first remove the unique name index on the
iterationsandareastable before we modify the data.In a previous attempt (#2312) I haven't moved the removal of the index enough up.
This should fix the migration issue that was visible here: openshiftio/saas-openshiftio#1082