This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
Add support for system_* fields along with system.* fields #2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarifibrahim
changed the title
Merge jarifibrahim/osio-story-743-rename-fields into fabric8-wit/osio-story-743-rename-fields.
…ric8-services/fabric8-wit into osio-story-743-rename-fields
* Add replaceFieldName and addFieldName with tests * Remove unnecessary log.Error from golden_files_test.go * Fix failing test in expression_compiler_blackbox_test.go * Skip FullTextSearch and iteration test until migrations are added * Add golden files with old and new field names * Add todo to skipped tests * Add foo.bar test for expression_compiler * fix TODO formatting
…ric8-services/fabric8-wit into osio-story-743-rename-fields
* Change workitemtype response payload * Update golden files related to workitemtype response change
…ric8-services/fabric8-wit into osio-story-743-rename-fields
* Add event_name attribute to the event response * fix golden files related to workitem_event * Rename event_name to onField in event/show response * Update golden files * fix typo
…ric8-services/fabric8-wit into osio-story-743-rename-fields
* Add migration for workitem_type field renames * Add field rename migrations for work_items and work_item_revisions table
…ric8-services/fabric8-wit into osio-story-743-rename-fields
* Add migration for TSV vector and triggers for field renames * Remove out of date comment
…ric8-services/fabric8-wit into osio-story-743-rename-fields
jarifibrahim
changed the title
…ifibrahim/fabric8-wit into osio-story-743-rename-fields
kwk
suggested changes
Dec 8, 2018
There was a problem hiding this comment.
@jarifibrahim please do not merge before I'm back from PTO.
kwk
approved these changes
Jan 22, 2019
|
[test] |
jarifibrahim
added a commit
to jarifibrahim/fabric8-wit
that referenced
this pull request
Jan 22, 2019
jarifibrahim
added a commit
that referenced
this pull request
Jan 23, 2019
…2341)" (#2401) This reverts commit 587d0d2. Revert "Add support for system_* fields along with system.* fields (#2341)" This reverts commit 587d0d2. #2341 was merged but the `core-97` deployment was failing. This PR reverts the changes. A possible reason for the deployment failure could be the huge database migration. The field rename PR updates **every row of 3 tables**. This is a database intensive operation and would take some amount of time to complete. But since it didn't complete within the timeout, openshift marks the pod as `unhealthy` and kills it. A new pod would come up and the same cycle would repeat. Kibana logs - https://logs.dsaas-stg.openshift.com/app/kibana#/discover?_g=(refreshInterval:(display:Off,pause:!f,value:0),time:(from:'2019-01-22T12:50:00.000Z',mode:absolute,to:'2019-01-22T13:20:00.000Z'))&_a=(columns:!(_source),filters:!(),index:'project.dsaas-preview.6e520a9f-d097-11e8-9fb7-121499db9246.*',interval:auto,query:(query_string:(analyze_wildcard:!t,query:'kubernetes.labels.deployment:core-97')),sort:!('@timestamp',desc)) This shows the Kibana logs for the actual pod: [`kubernetes.pod_name:"core-97-6cjh9" AND kubernetes.namespace_name:"dsaas-preview"`](https://logs.dsaas-stg.openshift.com/app/kibana#/discover?_g=(time:(from:now-1w,mode:relative,to:now))&_a=(columns:!(kubernetes.container_name,message),index:'project.dsaas-preview.6e520a9f-d097-11e8-9fb7-121499db9246.*',interval:auto,query:(query_string:(analyze_wildcard:!t,query:'kubernetes.pod_name:%22core-97-6cjh9%22+AND+kubernetes.namespace_name:%22dsaas-preview%22')),sort:!('@timestamp',desc)))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2343
The following PRs have to be merged before this PR can be merged
Rename system.* to system_* in a some files Rename system.* to system_* in a some files #2330
Add temporary code for field rename Add temporary code for field rename #2333
Update /workitemtype response for field rename Update /workitemtype response for field rename #2335
Add event_name to the /workitem/event response Add onField to the /workitem/event response #2337
Add migrations for field name rename Add migrations for field name rename #2340
Enable skipped test for field rename and update TSV trigger Enable skipped test for field rename and update TSV trigger #2342