Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Rename Iteration resolved_parent_path to parent_path_resolved #2373

Closed
wants to merge 3 commits into from

Conversation

sahil143
Copy link

@sahil143 sahil143 commented Dec 10, 2018

Taken From openshiftio/openshift.io#4589

Issue Overview

Response for https://prod-preview.openshift.io/api/spaces/${SPACE_ID}/iterations

{
 data: [
       { 
         attributes: {
            parent_path: "/",
            resolved_parent_path: "/ "
            ...
         }
         ...
       }
       ...
]}

Response for https://prod-preview.openshift.io/api/spaces/${SPACE_ID}/areas

{
 data: [
       { 
         attributes: {
            parent_path: "/",
            parent_path_resolved: "/ "
            ...
         }
         ...
       }
       ...
]}

Either the name should be resolved_parent_path or parent_path_resolved?

This PR deprecates resolved_parent_path field and adds a new field parent_path_resolved.
resolved_parent_path will be removed once the client migrates to the new field.
Issue to track removal of de[recated field: #2374

@codecov
Copy link

codecov bot commented Dec 10, 2018

Codecov Report

Merging #2373 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2373      +/-   ##
==========================================
+ Coverage   67.82%   67.82%   +<.01%     
==========================================
  Files         183      183              
  Lines       17994    17995       +1     
==========================================
+ Hits        12204    12206       +2     
  Misses       4616     4616              
+ Partials     1174     1173       -1
Impacted Files Coverage Δ
controller/iteration.go 78.44% <100%> (+0.05%) ⬆️
workitem/workitem_repository.go 67.79% <0%> (-0.23%) ⬇️
controller/workitem.go 78.59% <0%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c71948...75320fa. Read the comment docs.

@sahil143 sahil143 closed this Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants