Prepare for 3.2.0.Final keycloak deployment #34

sbose78 · 2017-07-12T10:05:47Z

Modified git clone steps to use the tag
Modified the dist name referred to, in Dockerfile
Modified the standalon-*.xml files to keep the changes made by "OpenShift.io team", but discarded the changes specific to wildfly versions.

sbose78 · 2017-07-12T12:13:36Z

compiled and created https://hub.docker.com/r/sbose78/keycloak-3.2.0
deployed on http://keycloak-test-kc.dev.rdu2c.fabric8.io

Tested out the following

token generation using grant_type=password
Space creation : ./bin/wit-cli create space --key $ALM_TOKEN --payload '{ "data":{ "type":"spaces" , "attributes":{"name":"testuser-space-1"}}}' -H localhost:8080 --pp This covers a lot of endpoints.
Collaborators : ./bin/wit-cli add collaborators --key $ALM_TOKEN --spaceID "5d8165b7-e07d-463d-b940-111fb2aae3dd" --identityID "ac5a1aee-1aae-4bbb-a21a-0f1e4d081a46" -H localhost:8080 --pp
Login : Tested out login using Facebook.
Linking : Tested out linking github.

So, we are Green with respect to functionality.

sbose78 · 2017-07-12T12:15:43Z

[test]

sbose78 · 2017-07-12T15:26:14Z

A couple of kerberos related tests are failing .

alexeykazakov · 2017-07-12T23:07:35Z

@sbose78 I don't know why but these tests always fail here. It's not critical bc the same tests pass in fabric8-services/keycloak in Travis. Don't know why the same tests fail in centos-ci.
So, it's not a blocker for this PR but we need to investigate and fix it (separately).

magick93 · 2017-07-14T08:43:29Z

@sbose78 - Firstly, apologies for writing here as my question is not directly related to this PR.

Im interested in using sbose78/keycloak-3.2.0. However, I couldnt find the source for this. I am trying to understand what env vars are needed to run this in Openshift. Can you help?

sbose78 · 2017-07-14T08:50:52Z

Hi @magick93 , Do you mind heading over to the #keycloak irc channel on freenode ? I could assist you there :)

hectorj2f · 2017-07-17T08:18:50Z

docker/standalone.xml

@@ -178,7 +176,7 @@
            </concurrent>
            <default-bindings context-service="java:jboss/ee/concurrency/context/default" datasource="java:jboss/datasources/ExampleDS" managed-executor-service="java:jboss/ee/concurrency/executor/default" managed-scheduled-executor-service="java:jboss/ee/concurrency/scheduler/default" managed-thread-factory="java:jboss/ee/concurrency/factory/default"/>
        </subsystem>
-        <subsystem xmlns="urn:jboss:domain:ejb3:5.0">
+        <subsystem xmlns="urn:jboss:domain:ejb3:4.0">


wow, the downgrade the version... that is weird

I found this change in the generated distribution/server-dist/target/keycloak-3.2.0.Final/standalone/configuration/standalone.xml

hectorj2f · 2017-07-17T08:19:01Z

docker/standalone.xml

@@ -132,7 +130,7 @@
            </formatter>
        </subsystem>
        <subsystem xmlns="urn:jboss:domain:bean-validation:1.0"/>
-        <subsystem xmlns="urn:jboss:domain:datasources:5.0">
+        <subsystem xmlns="urn:jboss:domain:datasources:4.0">


also here ? there is a downgrade of the used version

I found this change in the generated distribution/server-dist/target/keycloak-3.2.0.Final/standalone/configuration/standalone.xml

hectorj2f · 2017-07-17T08:19:50Z

docker/standalone.xml

@@ -1,6 +1,6 @@
-<?xml version="1.0" ?>
+<?xml version='1.0' encoding='UTF-8'?>


Did they add this encoding ?

I found this change in the generated distribution/server-dist/target/keycloak-3.2.0.Final/standalone/configuration/standalone.xml

Alright! I just wanted to be sure ;)

hectorj2f · 2017-07-17T08:20:15Z

docker/standalone-ha.xml

            <datasources>
+                <datasource jndi-name="java:jboss/datasources/ExampleDS" pool-name="ExampleDS" enabled="true" use-java-context="true">


We don need this example datasource

Thanks for the review, will remove. This came in as part of distribution/server-dist/target/keycloak-3.2.0.Final/standalone/configuration/standalone-ha.xml

removed here : ae0e9ff

hectorj2f · 2017-07-17T08:21:15Z

docker/standalone-ha.xml

@@ -95,15 +93,20 @@
                    <named-formatter name="COLOR-PATTERN"/>
                </formatter>
            </console-handler>
+            <periodic-rotating-file-handler name="FILE" autoflush="true">


We don't need to configure any file handler

Thanks for the review, will remove. This came in as part of distribution/server-dist/target/keycloak-3.2.0.Final/standalone/configuration/standalone-ha.xml

removed fb8b1a6

hectorj2f

I made some questions and asked for some changes

hectorj2f · 2017-07-17T08:22:28Z

cico_setup.sh

@@ -46,7 +46,7 @@ function install_deps() {

 function build() {
  echo 'CICO: Cloning keycloak source code repo'
-  git clone https://github.com/fabric8-services/keycloak.git --branch master
+  git clone -b 3.2.0.Final  --depth 1 https://github.com/fabric8-services/keycloak.git


Just a question, I might miss something but we're not using on purpose master. Why do we want to start using again different branches ? @alexeykazakov

Here's some context about how we arrived at this : fabric8-services/keycloak#93 (comment)

But I feel slightly stronger about having the branch deployed into production instead of master specifically for keycloak.., that way.. if we push to https://github.com/fabric8-services/keycloak-deployment 's master, we needn't end up deploying changes in https://github.com/fabric8-services/keycloak 's master ( which could have changes we just took in ).

Okay, it is clear now, 👍

sbose78 · 2017-07-17T08:36:15Z

Hi @hectorj2f , I took in the changes from the standalone-*.xml created in the distribution/server-dist/target/keycloak-3.2.0.Final/standalone/configuration/standalone.xml . That's where the changes in version ( downgrading ) was present. I'm guessing the downgrading is because they moved to wildfly 10 instead of 11 ?

hectorj2f · 2017-07-17T10:35:40Z

docker/standalone-ha.xml

@@ -118,6 +113,7 @@
                <!--   xxxxxxxxxxxxxxxxxxxxxxxxx   -->
                <handlers>
                    <handler name="CONSOLE"/>
+                    <handler name="FILE"/>


Let's remove the creation of a file handler for the logging. It takes a lot of resources from KC which already uses a lot. We don't make use of the FILE handler but let's avoid its creation.

hectorj2f · 2017-07-17T10:36:34Z

docker/standalone-ha.xml

@@ -166,8 +162,9 @@
                    <managed-scheduled-executor-service name="default" jndi-name="java:jboss/ee/concurrency/scheduler/default" context-service="default" hung-task-threshold="60000" keepalive-time="3000"/>
                </managed-scheduled-executor-services>
            </concurrent>
+            <default-bindings context-service="java:jboss/ee/concurrency/context/default" datasource="java:jboss/datasources/ExampleDS" managed-executor-service="java:jboss/ee/concurrency/executor/default" managed-scheduled-executor-service="java:jboss/ee/concurrency/scheduler/default" managed-thread-factory="java:jboss/ee/concurrency/factory/default"/>


This will fail because the datasource exampleDS doesn't exist anymore

Thanks, removing it, and testing it out.

removed : 3f8153d

hectorj2f

I added two minor comments. We should test that this image works. Did you try it @sbose78 ?

sbose78 · 2017-07-17T10:40:46Z

I am testing it end-to-end @hectorj2f after the new changes , will update here when done.

sbose78 · 2017-07-17T11:52:29Z

Did the following after making the recent changes :

created an image by doing a $ docker build --tag sbose78/keycloak-3.2.0 .
deployed it on the dev cluster
check the server version deployed from the keycloak UI ( to ensure its really 3.2 ;) )
ran tests against fabric8-wit & tried out space creation.

All looks GREEN to me.

Is this the right way to test , @hectorj2f
I was wondering if I should deploy the image which was generated as part of this PR's CI kick-off ?

hectorj2f · 2017-07-18T19:17:22Z

@sbose78 if you play with fabric8-platform and it worked it is good. But, perhaps, we could also try in clustered mode.

hectorj2f · 2017-07-19T11:44:39Z

docker/standalone-ha.xml

@@ -101,9 +99,6 @@
            <logger category="org.jboss.as.config">
                <level name="DEBUG"/>
            </logger>
-            <logger category="org.jgroups">


you removed this ... that we added before

This wasn't found in the 'new' distribution/server-dist/target/keycloak-3.2.0.Final/standalone/configuration/standalone.xml when i did the build. Should I put it back?

yes, we added to check things at infisnispan level. This is a temporal change that we need to evaluate the errors in the clustered mode.

@sbose78 why don't you add it ?

hectorj2f · 2017-07-19T12:17:03Z

lgtm

Prepare for 3.2.0.Final keycloak deployment

359d4c8

sbose78 added 3 commits July 13, 2017 00:11

put back

f67ba38

whitespaces

6e394b2

whitespaces

b740870

alexeykazakov requested a review from hectorj2f July 12, 2017 23:14

hectorj2f reviewed Jul 17, 2017

View reviewed changes

hectorj2f suggested changes Jul 17, 2017

View reviewed changes

sbose78 added 2 commits July 17, 2017 15:41

remove exampleDS

ae0e9ff

remove file handler

fb8b1a6

hectorj2f reviewed Jul 17, 2017

View reviewed changes

hectorj2f approved these changes Jul 17, 2017

View reviewed changes

remove usages of exampleDS

3f8153d

sbose78 mentioned this pull request Jul 17, 2017

Upgrade keycloak to 3.2.0 fabric8-services/fabric8-auth#1

Closed

alexeykazakov approved these changes Jul 18, 2017

View reviewed changes

remove FILE handler

308efcf

remove FILE handler

f36cb3a

hectorj2f reviewed Jul 19, 2017

View reviewed changes

jgroups logger

ac52da3

hectorj2f merged commit d17eb5e into fabric8-services:master Jul 19, 2017

		@@ -1,6 +1,6 @@
		<?xml version="1.0" ?>
		<?xml version='1.0' encoding='UTF-8'?>

		<datasources>
		<datasource jndi-name="java:jboss/datasources/ExampleDS" pool-name="ExampleDS" enabled="true" use-java-context="true">

Prepare for 3.2.0.Final keycloak deployment #34

Prepare for 3.2.0.Final keycloak deployment #34

Conversation

sbose78 commented Jul 12, 2017 • edited Loading

sbose78 commented Jul 12, 2017 • edited Loading

sbose78 commented Jul 12, 2017

sbose78 commented Jul 12, 2017

alexeykazakov commented Jul 12, 2017

magick93 commented Jul 14, 2017

sbose78 commented Jul 14, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hectorj2f Jul 17, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hectorj2f Jul 17, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hectorj2f left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sbose78 Jul 17, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sbose78 commented Jul 17, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hectorj2f left a comment

Choose a reason for hiding this comment

sbose78 commented Jul 17, 2017 • edited Loading

sbose78 commented Jul 17, 2017 • edited Loading

hectorj2f commented Jul 18, 2017

Choose a reason for hiding this comment

sbose78 Jul 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hectorj2f commented Jul 19, 2017

sbose78 commented Jul 12, 2017 •

edited

Loading

sbose78 commented Jul 12, 2017 •

edited

Loading

hectorj2f Jul 17, 2017 •

edited

Loading

hectorj2f Jul 17, 2017 •

edited

Loading

sbose78 Jul 17, 2017 •

edited

Loading

sbose78 commented Jul 17, 2017 •

edited

Loading

sbose78 commented Jul 17, 2017 •

edited

Loading

sbose78 commented Jul 17, 2017 •

edited

Loading

sbose78 Jul 19, 2017 •

edited

Loading