-
Notifications
You must be signed in to change notification settings - Fork 86
The only Che stack that is used is the plain java one #1534
Comments
Let's use this to discuss the long term and short term plan. |
@l0rd can you be clarify that this issue is blocking the use of Che? |
I thought the only stack we were using was the one for vert.x. |
@joshuawilson no it's not blocking Che usage. It makes a the UX worst. A user needs to manually run |
The UX problem has been described by @burrsutter here: redhat-developer/rh-che#95. We need to discuss if it makes sense to implement a temporary workaround to address @burrsutter concern or if we can wait untill forge/chefile integration is completed. |
Thanks for the very comprehensive explanation of the situation @l0rd - very helpful! @joshuawilson is there anything we can do on the front-end carry the knowledge from the wizard (where we knew what stack they chose) into the workspaces page so that we can pass that into the "create workspace" action without adding a user-driven UI step for this? |
This needs to be discussed by the team. |
@l0rd what part is it that are missing ? Does che today read the file that Forge is generating or is it because Forge is not generating the file you need ? |
The Forge service needs to return the stack id to the UI so the Codebase can be created with the correct stack. If that is done, Codebases will call the CheStarter with the stack id. |
The Forge UI adds an annotation to the BuildConfig with the correct Che Stack ID. This is also returned to the front end as the We just need to use that stack ID value in the wizard front end when we create the Codebase (and for the Create Workspace to use that value too) apiVersion: v1
kind: BuildConfig
metadata:
annotations:
che.fabric8.io/stack: vert.x
labels:
space: beer
name: beer2 |
Forge can generate a |
@jstrachan correct, It is better to adopt the |
@gorkem is there a way to pass the stack id into the create Codebase REST call? |
che-starter REST api has a parameter for stack ID but codebases are on core @aslakknutsen can provide the best information. |
che-starter supports all 5 stacks with project-type mapping [1]. So, if Forge is able to pass stack id to Codebases, che-starter will be able to create a workspace against it (AFAIK, currently platform is always passing |
@ibuziuk cool thx; so Forge passes the stack id to the fabric8-ui. I've split this into separate sub issues:
we can probably close this one now? Or use wait until those 2 issues are fixed? |
@jstrachan I would prefer to keep this open and log here the work related to Chefiles and factories. |
@l0rd The title of this issue is wrong at this point, correct? Could you rename it to reflect the CheFile/Factories issues? |
@aslakknutsen I'm going to close this since the original issue has been solved. The Chefile/factory issue already exists in eclipse/che repo: eclipse-che/che#4362 |
Even if Che has a distinct stack for every quick start (vertx, spring boot, wildfly) these are never used in OSIO. When Platform starts a Che workspace it uses always the same plain Java stack even if user has selected a vertx quickstart.
It's a pity because these stacks would ensure a better UX for the developers (dependencies are pre-downloaded and commands to build and run applications are pre-configured).
The clean solution to solve that:
This solution can take many weeks to be implemented.
A short term solution could be to prompt the user with five options (plain java, vertx, spring boot, wildfly swarm, node js) when it select "create workspace". That's not a nice option from a UX point of view: the user is asked twice about the technology stack. But once the IDE is started he will be happy to find the commands and the pre-downloaded dependencies.
cc/ @gorkem @joshuawilson @burrsutter @benoitf @ibuziuk @aslakknutsen
The text was updated successfully, but these errors were encountered: