feat(rpt-interceptor): add RPT refresh logic to auth interceptor & cleanup code

[rohitkrai03]

Fixes fabric8-services/fabric8-auth#596

• Adds logic to refresh RPT tokens by intercepting the response.
• Adds logic to check for valid auth, wit or sso URLs where the interceptor needs to intercept.
• Removes unnecessary use of isAuthenticationError since interceptor is going to handle that.
• Adds related tests.
• General code cleanup.

[joshuawilson]

If we don't need isAuthenticationError then why was it moved in here?

[rohitkrai03]

We do use isAuthenticationError but only inside the interceptor and that is why i moved it here. Earlier it was being used by other services as well.

[joshuawilson]

I'm not understanding why make the change. If it is external it keeps the code clean, it can be tested and it can be shared. It is more functional to keep it external.

What is the benefit of moving it inside?

[rohitkrai03]

It will not be used anywhere else since interceptor does that already for every response. So, it made more sense to keep it tightly coupled as a bussiness logic to auth interceptor rather than keeping it external. Its just separation of concern for me.

Before moving to interceptors we had a shared http.service which had this logic but we moved it outside because we needed other services to explicitly check for the same errors. Since, we have interceptors now we do not need any other service to use this explicitly.

[fabric8cd]

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀