Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPLOYMENTS_DIR override #146

Closed
edewit opened this issue May 1, 2018 · 1 comment
Closed

DEPLOYMENTS_DIR override #146

edewit opened this issue May 1, 2018 · 1 comment

Comments

@edewit
Copy link

edewit commented May 1, 2018

I would like to override DEPLOYMENTS_DIR right now it seems to be fixed
@edewit edewit changed the title deployments_dir override DEPLOYMENTS_DIR override May 1, 2018
@vorburger
Copy link
Collaborator

@edewit what an incredible coincidence - I just thought of the same! Maybe it's because I'm sitting right next to you... 😸 I think this is easy - let me try to raise a PR for this right away!

vorburger added a commit to vorburger/s2i that referenced this issue May 1, 2018
@vorburger
make DEPLOYMENTS_DIR overridable (fabric8io-images#146)
a53619c
@vorburger vorburger mentioned this issue May 1, 2018
Merged
vorburger added a commit to vorburger/s2i that referenced this issue May 1, 2018
@vorburger
make DEPLOYMENTS_DIR overridable (fabric8io-images#146)
c05d2bb 
and mkdir -p it, because it can	(and in	our use	case does) not exist, yet.
vorburger added a commit to vorburger/s2i that referenced this issue May 1, 2018
@vorburger
make DEPLOYMENTS_DIR overridable (fabric8io-images#146)
b0d87a3 
and mkdir -p it, because it can	(and in	our use	case does) not exist, yet.
vorburger added a commit to OASIS-learn-study/minecraft-storeys-maker that referenced this issue May 1, 2018
@vorburger
add .s2i/environment and rm Dockerfile (#19)
b8dfb29 
To work, this requires vorburger/s2i#gradle which includes:
 * fabric8io-images/s2i#146
 * fabric8io-images/s2i#118
vorburger added a commit to vorburger/s2i that referenced this issue May 1, 2018
@vorburger
make DEPLOYMENTS_DIR overridable (fabric8io-images#146)
1c3f7aa 
and mkdir -p it, because it can	(and in	our use	case does) not exist, yet.
vorburger added a commit to vorburger/s2i that referenced this issue May 1, 2018
@vorburger
make DEPLOYMENTS_DIR overridable (fabric8io-images#146)
5faff70 
and mkdir -p it, because it can	(and in	our use	case does) not exist, yet.
rhuss pushed a commit to vorburger/s2i that referenced this issue May 15, 2018
@vorburger @rhuss
make DEPLOYMENTS_DIR overridable (fabric8io-images#146)
48902da 
and mkdir -p it, because it can	(and in	our use	case does) not exist, yet.
@rhuss rhuss closed this as completed in be778c1 May 15, 2018
rhuss added a commit that referenced this issue May 15, 2018
@rhuss
Merge pull request #147 from vorburger/DEPLOYMENTS_DIR
5804783 
make DEPLOYMENTS_DIR overridable (#146)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edewit @vorburger