Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Maven Wrapper support #152

Merged
merged 3 commits into from
May 15, 2018
Merged

Conversation

vorburger
Copy link
Collaborator

@vorburger vorburger commented May 2, 2018

@vorburger
Copy link
Collaborator Author

@rhuss & Co. how about this?

I could use this to throw https://github.com/vorburger/opendaylight-bot on OpenShift...

PS: This will probably conflict with some of my other pending PRs; get those in first, then I'll rebase it.

vorburger added a commit to vorburger/opendaylight-bot that referenced this pull request May 2, 2018
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, but I wonder whether we should include Maven wrapper support also in the RHEL images.

I.e. to pick up a local mvn when provided in the source code to compile.

wdyt, @jamesnetherton @dhirajsb ?

@jamesnetherton
Copy link
Contributor

I think we should only support this in the community images.

@vorburger
Copy link
Collaborator Author

@jamesnetherton so how exactly do we want to "condition" this? Similar to the Gradle "feature switch" in #121, so if I added a withMavenWrapper true/false to images.yml and {{? fp.config.base.withMavenWrapper }} in the template - would that work for you?

@jamesnetherton
Copy link
Contributor

@vorburger yes, a simple feature switch would be fine.

@@ -137,14 +137,16 @@ function build_maven() {

local mvn="mvn"
if [ -f "mvnw" ]; then
echo "Using local mvnw"
./mvnw --version
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is kind of redundant with line 148 below, but never mind

@vorburger
Copy link
Collaborator Author

@jamesnetherton @rhuss done; withMavenWrapper, for now adds ./mvnw only for community image.

Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm

@rhuss rhuss merged commit de582c8 into fabric8io-images:master May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants