Use exponential backoff when retrying from 10ms to 100ms

fabric8io · Mar 30, 2021 · b9708be · b9708be
1 parent 64dee37
commit b9708be
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/main/java/io/fabric8/maven/docker/service/RunService.java b/src/main/java/io/fabric8/maven/docker/service/RunService.java
@@ -21,6 +21,7 @@
 
 import java.io.File;
 import java.time.Duration;
+import java.time.temporal.ChronoUnit;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collection;
@@ -469,8 +470,8 @@ private void startContainer(ImageConfiguration imageConfig, String id, GavLabel
 
     private void updateMappedPortsAndAddresses(String containerId, PortMapping mappedPorts) throws DockerAccessException {
         RetryPolicy<Void> retryPolicy = new RetryPolicy<Void>()
-                .withMaxAttempts(10)
-                .withDelay(Duration.ofMillis(250))
+                .withMaxAttempts(20)
+                .withBackoff(10, 100, ChronoUnit.MILLIS)
                 .handle(PortBindingException.class)
                 .onFailedAttempt(f -> log.debug("Failed to update mapped ports for container %s (attempt %d), retrying", 
                         containerId, f.getAttemptCount()))

diff --git a/src/test/java/io/fabric8/maven/docker/service/RunServiceTest.java b/src/test/java/io/fabric8/maven/docker/service/RunServiceTest.java
@@ -371,7 +371,7 @@ public void failAfterRetryingIfInsufficientPortBindingInformation(
         new Expectations() {{
             docker.createContainer(withAny(new ContainerCreateConfig("img")), anyString); result = "containerId";
             portMapping.needsPropertiesUpdate(); result = true;
-            queryService.getMandatoryContainer("containerId"); result = container; times = 10;
+            queryService.getMandatoryContainer("containerId"); result = container; times = 20;
             container.isRunning(); result = true;
             container.getPortBindings(); result = new PortBindingException("5432/tcp", new Gson().fromJson("{\"5432/tcp\": []}", JsonObject.class));
         }};