Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply replacements to additional tags in: tags/tag #1367

Closed
Xyaren opened this issue Aug 20, 2020 · 3 comments · Fixed by #1491
Closed

Apply replacements to additional tags in: tags/tag #1367

Xyaren opened this issue Aug 20, 2020 · 3 comments · Fixed by #1491

Comments

@Xyaren
Copy link
Contributor

Xyaren commented Aug 20, 2020

This should be allowed:

<tags>
  <tag>%t</tag>
  <tag>%l</tag>
</tags>

But sadly isn't:
* tag part '%t' doesn't match allowed pattern '^[\w][\w.-]{0,127}$'

Replacements should be applied to the additional tags aswell.

@rhuss
Copy link
Collaborator

rhuss commented Aug 30, 2020

May I ask you what your use case is for using these tags ?

I remember darkly that the validation for tag values was the pattern referenced in the error message, but if you have a better reference for the pattern allowed for tags, please let me know.

@Xyaren Xyaren changed the title Applay replacements to additional tags in: tags/tag Apply replacements to additional tags in: tags/tag Aug 31, 2020
@Xyaren
Copy link
Contributor Author

Xyaren commented Aug 31, 2020

I would like to create an image i.e. with "latest" (if SNAPSHOT) "version-123456" (date) AND the exact defined verison develop-SNAPSHOT.
The replacements are not working in the additional tags like they do in the "real" tag

@rhuss
Copy link
Collaborator

rhuss commented Aug 31, 2020

I see. thought first that you wanted to use these tags literally :)

I think that is definitely a good idea and I happely would help to integrate a pull request with this feature (but don't have enough time to work on it on my own)

rohanKanojia pushed a commit that referenced this issue Sep 24, 2021
Fixes #1367

Signed-off-by: Tobias Günther <Xyaren@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants