Tagging during build/push #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Leibiger <p.leibiger@codecraft.de>
|
IMO this looks good to me. Just doing a small review and will then integrate into |
rhuss
added a commit
that referenced
this pull request
Feb 27, 2015
ImageName was refactored so that fullName now contains the tag as well (which should have been from the very first beginning). Added a <tags> section to the demo. Also tested it locally and it works fine for build and push. Integration tests are still pending (but they are overall as well).
rhuss
added a commit
that referenced
this pull request
Feb 27, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may not be complete and might just be a starting point for discussions.