Add a skipPom parameter, skipping a project if packaging is pom #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1388 +/- ##
============================================
+ Coverage 58.23% 58.79% +0.56%
- Complexity 1955 1974 +19
============================================
Files 162 162
Lines 9014 9014
Branches 1362 1362
============================================
+ Hits 5249 5300 +51
+ Misses 3295 3229 -66
- Partials 470 485 +15
|
|
SonarCloud Quality Gate failed.
|
rohanKanojia
reviewed
Mar 7, 2021
| @@ -137,6 +137,9 @@ By default a progress meter is printed out on the console, which is omitted when | |||
| | If set dont push any images even when `{plugin}:push` is called. | |||
| | `docker.skip.push` | |||
|
|
|||
| | *skipPom* | |||
| | If set to `true` this plugin will skip every projects, where `project.packaging` is set to `true`. Property: `docker.skip.pom` | |||
There was a problem hiding this comment.
I think there is a typo here:
Suggested change
| | If set to `true` this plugin will skip every projects, where `project.packaging` is set to `true`. Property: `docker.skip.pom` | |
| | If set to `true` this plugin will skip every projects, where `project.packaging` is set to `pom`. Property: `docker.skip.pom` |
Signed-off-by: Laszlo Stahorszki <laszlo.stahorszki@ropi.dev>
|
@rolaca11: Thanks a lot for this 👍 |
mabrarov
reviewed
Mar 30, 2021
| @@ -137,6 +137,9 @@ By default a progress meter is printed out on the console, which is omitted when | |||
| | If set dont push any images even when `{plugin}:push` is called. | |||
| | `docker.skip.push` | |||
|
|
|||
| | *skipPom* | |||
| | If set to `true` this plugin will skip every projects, where `project.packaging` is set to `pom`. Property: `docker.skip.pom` | |||
There was a problem hiding this comment.
This change breaks the table:
There should be 3 columns in each row:
| *skipPom*
| If set to `true` this plugin will skip every projects, where `project.packaging` is set to `pom`.
| `docker.skip.pom`
There was a problem hiding this comment.
@mabrarov: Thanks a lot for noticing, Could you please create a PR to fix this ?
There was a problem hiding this comment.
I've merged it into master. Thanks a lot for your quick PR :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usecase for this feature:
There are multiple projects which use the same docker-maven-plugin configuration. A logical way to extract that config to one place is to use the
pluginManagementtag.However, this leaves the need to define the plugin in every project wanting to use that configuration.
A ready solution is to define the plugin in the parent pom, but than the build will fail, because the docker build goal cannot find the packaged jar archive.
Here comes this PR, which tells the docker build goal to skip if the currently built project is a pom.