Provide exception messages that occurred during stop #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eneric message - related to fabric8io#1251 Signed-off-by: Doyle Young <dyoung@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1435 +/- ##
============================================
+ Coverage 58.79% 59.02% +0.22%
- Complexity 1974 1981 +7
============================================
Files 162 162
Lines 9014 9018 +4
Branches 1362 1363 +1
============================================
+ Hits 5300 5323 +23
+ Misses 3229 3205 -24
- Partials 485 490 +5
|
rohanKanojia
reviewed
Mar 7, 2021
| runService.stopStartedContainers(false, true, true, testLabel); | ||
| fail("Should have thrown exception"); | ||
| } catch (DockerAccessException | ExecException e) { | ||
| assertEquals(e.getLocalizedMessage(), "(TEST two,TEST one)"); |
There was a problem hiding this comment.
nit, these arguments should be in opposite order: assertEquals(expected, actual)
rohanKanojia
reviewed
Mar 7, 2021
|
|
||
| runService = new RunService(docker, queryService, tracker, logOutputSpecFactory, log); | ||
|
|
||
| try { |
There was a problem hiding this comment.
I think maybe we can improve this by using assertThrows method like this:
Exception thrownException = assertThrows(DockerAccessException.class, () -> runService.stopStartedContainers(false, true, true, testLabel));
assertEquals("(TEST two,TEST one)", thrownException.getLocalizedMessage());WDYT?
|
@doyleyoung: Thanks a lot for your PR 👍 . It looks good to be merged, I just have minor comment regarding the test. |
rhuss
approved these changes
Mar 7, 2021
…aven-plugin into list_shutdown_errors
|
@rohanKanojia @rhuss updated the test. Thanks for the awesome project 👍 |
rohanKanojia
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide exception messages that occurred during stop, rather than generic message - related to #1251
Signed-off-by: Doyle Young dyoung@gmail.com