feat : Add support for Pull Image options - createImageOptions #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanKanojia
force-pushed
the
pr/pull-image-options
branch
2 times, most recently
from
bfc43e1
to
b7272ff
Compare
Port of eclipse-jkube/jkube#1241 Just like we have buildOptions for providing build API query parameters via plugin, add support for providing API query parameters for pulling images via providing them as map in `<image>` > `<build>` > `<createImageOptions>` Signed-off-by: Rohan Kumar <rohaan@redhat.com>
) Right now we need to pull base images (ones specified in `FROM` statements) before doing the actual build. DockerfileUtil doesn't seem to be handling the case when an option is specified in `FROM` statement. It just assumes second token to be image name. Add check to ignore token starting with `--` so that it doesn't fail the build. For specifiying pull platform it would need to be set in image configuration build createImageOptions Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
force-pushed
the
pr/pull-image-options
branch
from
b7272ff
to
f1be014
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1516
createImageOptions(Port of feat: enable Create Image (pull) HTTP API options eclipse-jkube/jkube#1241 like we have buildOptions for providing build API query parameters via plugin, add support for providing API query parameters for pulling images via providing them as map in<image>><build>><createImageOptions>--so that it doesn't fail thebuild. For specifying pull platform it would need to be set in image
configuration build createImageOptions