[#1528] determineFinalArgValue respect default value if key exists but value is null #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1529 +/- ##
=========================================
Coverage 62.01% 62.01%
- Complexity 2189 2190 +1
=========================================
Files 167 167
Lines 9645 9645
Branches 1455 1455
=========================================
Hits 5981 5981
Misses 3139 3139
Partials 525 525
|
rohanKanojia
changed the title
…exists but value is null Signed-off-by: thorsten.wendelmuth <thorsten.wendelmuth@gmx.de>
rohanKanojia
force-pushed
the
issue_1528_useDefaults_onARGprovidingKey_butNullValue
branch
from
b5e2cdc
to
6c7c06e
Compare
rohanKanojia
approved these changes
Feb 24, 2022
|
Kudos, SonarCloud Quality Gate passed! |
|
@twendelmuth : Thanks for your PR 👍 . Would you be needing a patch release with this bugfix? |
twendelmuth
deleted the
issue_1528_useDefaults_onARGprovidingKey_butNullValue
branch
|
@rohanKanojia I'd prefer it - unless you're planning to release 0.40.0 anyway soon 👍 |
|
@twendelmuth : I've cut 0.39.1 today https://repo1.maven.org/maven2/io/fabric8/docker-maven-plugin/0.39.1/ . Would appreciate if you could try it out whenever you get time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1528
See #1528 - will return the default value when
argMap.getValue() == null