Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using buildx, do not force build of native platform #1577

Merged
merged 1 commit into from
Jul 1, 2022
Merged

When using buildx, do not force build of native platform #1577

merged 1 commit into from
Jul 1, 2022

Conversation

chonton
Copy link
Contributor

@chonton chonton commented Jul 1, 2022

closes #1572

@sonarcloud
Copy link

sonarcloud bot commented Jul 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #1577 (54fb4c1) into master (d3cec33) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1577      +/-   ##
============================================
+ Coverage     62.83%   62.84%   +0.01%     
- Complexity     2150     2151       +1     
============================================
  Files           170      170              
  Lines          9906     9909       +3     
  Branches       1356     1357       +1     
============================================
+ Hits           6224     6227       +3     
  Misses         3171     3171              
  Partials        511      511              
Impacted Files Coverage Δ
...io/fabric8/maven/docker/service/BuildXService.java 72.78% <100.00%> (+0.56%) ⬆️

@chonton
Copy link
Contributor Author

chonton commented Jul 1, 2022

@rohanKanojia please review

@rohanKanojia rohanKanojia merged commit d5cc609 into fabric8io:master Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native platform image also forcely built with buildx config [native arch forcely added]
2 participants