Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#862 - Fix for hanging wait on log #904

Merged
merged 3 commits into from
Jan 16, 2018
Merged

#862 - Fix for hanging wait on log #904

merged 3 commits into from
Jan 16, 2018

Conversation

FSeidinger
Copy link
Contributor

Fixed entity stream closing
Added callback mechanism to signal wait lock condition to main thread including tests
Changed mocked DockerAccess dependency including expectations in LogWaitChecker tests

@codecov
Copy link

codecov bot commented Nov 28, 2017

Codecov Report

Merging #904 into master will increase coverage by 0.27%.
The diff coverage is 82.14%.

@@             Coverage Diff              @@
##             master     #904      +/-   ##
============================================
+ Coverage     51.75%   52.03%   +0.27%     
- Complexity     1221     1232      +11     
============================================
  Files           141      142       +1     
  Lines          7168     7163       -5     
  Branches        964      964              
============================================
+ Hits           3710     3727      +17     
+ Misses         3142     3122      -20     
+ Partials        316      314       -2
Impacted Files Coverage Δ Complexity Δ
...io/fabric8/maven/docker/wait/LogMatchCallback.java 100% <100%> (ø) 8 <8> (?)
...a/io/fabric8/maven/docker/wait/LogWaitChecker.java 93.33% <100%> (+17.01%) 6 <4> (+3) ⬆️
.../fabric8/maven/docker/access/log/LogRequestor.java 77.52% <58.33%> (+13.69%) 13 <3> (ø) ⬇️

Frank Seidinger and others added 3 commits January 16, 2018 09:42
Fixed entity stream closing
Added callback mechanism to signal wait lock condition to main thread including tests
Changed mocked DockerAccess dependency including expectations in LogWaitChecker tests
@rhuss
Copy link
Collaborator

rhuss commented Jan 16, 2018

Thanks a lot and sorry for the long delay.

I did a rebase and some minor cosmetics.

'hope I can get out 0.24.0 with this fix this week.

@rhuss rhuss merged commit c899fbe into fabric8io:master Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants