This repository has been archived by the owner on Sep 19, 2018. It is now read-only.
1.7.6 from 1.3.0 #61
Open
1.7.6 from 1.3.0 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebrigand
commented
Jan 12, 2017
ebrigand
commented
- plugin build process is coming from the tag elasticsearch-cloud-kubernetes-2.4.0_01 (to be able to use the Dockerfile and to have the last building process coming with the last maven pom file)
- Dockefile install ES 1.7.6
- Java class are coming from the tag elasticsearch-cloud-kubernetes-1.3.0
jimmidyson
suggested changes
Jan 12, 2017
LICENSE.txt
Outdated
| @@ -1,3 +1,18 @@ | |||
| ==== | |||
There was a problem hiding this comment.
This file should not have changed.
NOTICE.txt
Outdated
| @@ -0,0 +1,16 @@ | |||
| ==== | |||
There was a problem hiding this comment.
This file isn't actually required.
README.md
Outdated
| @@ -23,10 +28,11 @@ Here is a simple sample configuration: | |||
|
|
|||
| ```yaml | |||
| cloud: | |||
| k8s: | |||
| servicedns: ${SERVICE_DNS} | |||
| kubernetes: | |||
There was a problem hiding this comment.
These options look like from later version? Can you update please to reflect the 1.3.x config?
README.md
Outdated
| discovery: | ||
| type: io.fabric8.elasticsearch.discovery.k8s.K8sDiscoveryModule | ||
| type: kubernetes |
…csearch-cloud-kubernetes-2.4.0_01
…ince what we had was a copy past of the official dockerfile and no need of an entrypoint, it will use the official one
ebrigand
commented
Jan 16, 2017
There was a problem hiding this comment.
Review done and i fixed some small glitch like I was using our docker id so i put back fabric8.
And I decided to change the Dockerfile to put a FROM using the official image instead of using a full copy past of their Dockerfile, same for the entry-point.sh we don't need it since it s the same as the official one
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.