Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for external resources reference; e.g. app tempplates #804

Closed
alesj opened this issue Feb 3, 2017 · 9 comments
Closed

Allow for external resources reference; e.g. app tempplates #804

alesj opened this issue Feb 3, 2017 · 9 comments
Assignees
Labels
cat/feature Feature request prio/p2 Some priority size/m Medium
Projects

Comments

@alesj
Copy link

alesj commented Feb 3, 2017

It would be useful to be able to include external k8s / OpenShift resources.
e.g. a SpringBoot app that requires RHT SSO could simply reference CE team's RHT SSO app template

(and not have to copy paste the resource file -- leave it to the original authors to be properly maintained)

@ro14nd ^^

@rhuss rhuss added the cat/feature Feature request label Feb 3, 2017
@rhuss
Copy link
Contributor

rhuss commented Feb 3, 2017

Yes, I think it makes sense to allow a list of URL in the plugin's configuration so that object definitions can be downloaded on the fly and added to the list of objects to process.

Maybe we should allow also a profile to be used so that these resource could be also enriched.

A suggestion could be:

<configuration>
  <extra>
     <remote>
        <url>https://github.com/jboss-openshift/application-templates/blob/master/sso/sso70-https.json</url>
        <!-- No enrichment --> 
        <profile>raw</profile>
     </remote>
   </extra>
</configuration>

or mabe embedded in the <resource> configuration. But the idea should be clear.

If this is given, then the openshift.yml should contain these templates, too (so that it can be distributed) along with the artifact. fabric8:apply should manage this as any other resource.

An alternative approach (or maybe even in addition) to use fragment files which are named like sso-external.yml

and has a content like:

url: https://github.com/jboss-openshift/application-templates/blob/master/sso/sso70-https.json

@alesj
Copy link
Author

alesj commented Feb 3, 2017

Perhaps fragments files are better approach,
as you then don't need to change the plugin config -- can have the same for all different artifacts.

@cmoulliard
Copy link
Contributor

Whenever which approach we decide to adopt, how it be possible to specify the parameters to be used tu customize the application to be created from the template ?

@rhuss
Copy link
Contributor

rhuss commented Mar 6, 2017

@cmoulliard Sorry, don't get your question. This issue is not about applying a template but getting the template object it into OpenShift by referring to an external source.

Wdym with 'specify the parameters' ?

@cmoulliard
Copy link
Contributor

cmoulliard commented Mar 6, 2017

@rhuss The question of @alesj concerns the following point. Is it possible to pass to the f-m-plugin a reference to an openshift template instead of decomposing an openshift template into the corresponding objects as we did here
If f-m-p could support this option which is to deploy the openshift template, then we should offer the possibility to set the parameters to create the application from the template

@rhuss
Copy link
Contributor

rhuss commented Mar 6, 2017

No, there is no way to apply / fill in value for template parameters when doing a fabric8:apply. And tbh, this is indeed a different story for which a different issue should be created.

The question will be, from where the values should come from. Maven properties ? standard input ? External property file ? Please open an issue for this, maybe with your preferred way how to provide those values.

@stale
Copy link

stale bot commented Oct 4, 2018

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue/PR considered to be stale label Oct 4, 2018
@rhuss rhuss removed the status/stale Issue/PR considered to be stale label Oct 5, 2018
@rhuss
Copy link
Contributor

rhuss commented Oct 5, 2018

Might be still useful, adding it to the backlog.

@rhuss rhuss added size/m Medium prio/p2 Some priority labels Oct 5, 2018
@rhuss rhuss added this to Backlog in Backlog Oct 6, 2018
@rohanKanojia rohanKanojia moved this from Backlog to Plan in next Sprint in Backlog Dec 19, 2018
@stale
Copy link

stale bot commented Jan 3, 2019

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue/PR considered to be stale label Jan 3, 2019
@rohanKanojia rohanKanojia removed the status/stale Issue/PR considered to be stale label Jan 3, 2019
@lordofthejars lordofthejars self-assigned this Jan 16, 2019
@lordofthejars lordofthejars added this to Planned in Sprint #175 via automation Jan 17, 2019
@lordofthejars lordofthejars removed this from Plan in next Sprint in Backlog Jan 17, 2019
@lordofthejars lordofthejars moved this from Planned to In Progress in Sprint #175 Jan 17, 2019
lordofthejars added a commit to lordofthejars/fabric8-maven-plugin that referenced this issue Jan 17, 2019
lordofthejars added a commit to lordofthejars/fabric8-maven-plugin that referenced this issue Jan 17, 2019
@lordofthejars lordofthejars moved this from In Progress to Review in Sprint #175 Jan 17, 2019
Sprint #175 automation moved this from Review to Done Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/feature Feature request prio/p2 Some priority size/m Medium
Projects
No open projects
Sprint #175
  
Done
Development

No branches or pull requests

5 participants