This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
Fix #1308 : upgrade kubernetes client to support OpenShift 3.9 and Kubernetes 1.8/1.9 #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanKanojia
added
group/openshift
rhuss
reviewed
Aug 22, 2018
| @@ -111,7 +111,7 @@ public void replicationControllerHandlerTest() { | |||
| assertFalse(replicationController.getSpec().getTemplate().getSpec().getVolumes().isEmpty()); | |||
| assertEquals("test",replicationController.getSpec().getTemplate().getSpec(). | |||
| getVolumes().get(0).getName()); | |||
| assertEquals("/test/path",replicationController.getSpec().getTemplate() | |||
| assertEquals("path",replicationController.getSpec().getTemplate() | |||
There was a problem hiding this comment.
Are you sure that you want to change the assert only ?
I mean, in before() you set up the path to "/test/path", so I'm not sure why you would expect a relative directory now in the generated objects.
There was a problem hiding this comment.
Oops, I interchanged parameters here ;-) . Thanks for noticing 😄
….9 and Kubernetes 1.8/1.9
rohanKanojia
force-pushed
the
upgradeKubernetesClient
branch
from
d9d74f2
to
b4f0356
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1308 #1271