Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Add Open Liberty Generator #1711

Merged
merged 5 commits into from
Oct 1, 2019

Conversation

brenthdaniel
Copy link
Contributor

Two pieces here:

  1. Add a generator for Open Liberty that extends the java-exec generator. It defaults webPort to the Liberty default port (9080) and adds an environment variable for use by S2I if it detects a Liberty runnable jar.
  2. Add Liberty's default web ports (9080, 9443) to the ExposeEnricher so that routes get generated.

Copy link
Member

@rohanKanojia rohanKanojia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR 👍

Could you please add unit test for OpenLibertyGenerator and a sample project/integration test for this as well? Also, would be super awesome if we can add it to our website documentation (docs/ folder)


public class OpenLibertyGenerator extends JavaExecGenerator {

private static final Object LIBERTY_SELF_EXTRACTOR = "wlp.lib.extract.SelfExtractRun";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, indentation slightly off here

@rohanKanojia rohanKanojia added the pr/changelog-entry-please Please add a changelog entry for this PR label Sep 23, 2019
@brenthdaniel
Copy link
Contributor Author

@rohanKanojia Sure, I didn't add unit tests initially because I didn't see them for most other generators. I added a couple of simple tests and documentation in the latest commit. I can add a more in depth sample later.

@rohanKanojia
Copy link
Member

@brenthdaniel : cool, thanks. Looking forward to getting this merged 😄

@codecov
Copy link

codecov bot commented Sep 30, 2019

Codecov Report

Merging #1711 into master will increase coverage by 0.19%.
The diff coverage is 70.17%.

@@             Coverage Diff              @@
##             master    #1711      +/-   ##
============================================
+ Coverage     33.98%   34.18%   +0.19%     
- Complexity     1105     1112       +7     
============================================
  Files           189      190       +1     
  Lines         10713    10769      +56     
  Branches       1745     1752       +7     
============================================
+ Hits           3641     3681      +40     
- Misses         6650     6661      +11     
- Partials        422      427       +5

@brenthdaniel
Copy link
Contributor Author

@rohanKanojia Hi, is there anything else needed for this PR?

@rohanKanojia
Copy link
Member

@brenthdaniel : just a tiny entry to changelog about this new feature 😄

@rohanKanojia rohanKanojia removed the pr/changelog-entry-please Please add a changelog entry for this PR label Oct 1, 2019
@rohanKanojia rohanKanojia merged commit 724bfae into fabric8io:master Oct 1, 2019
rohanKanojia added a commit to rohanKanojia/jkube that referenced this pull request Dec 20, 2019
+ Add a generator for Open Liberty that extends the java-exec generator. It defaults webPort to the Liberty default port (9080) and adds an environment variable for use by S2I if it detects a Liberty runnable jar.
+ Add Liberty's default web ports (9080, 9443) to the ExposeEnricher so that routes get generated.
rohanKanojia added a commit to rohanKanojia/jkube that referenced this pull request Dec 23, 2019
+ Add a generator for Open Liberty that extends the java-exec generator. It defaults webPort to the Liberty default port (9080) and adds an environment variable for use by S2I if it detects a Liberty runnable jar.
+ Add Liberty's default web ports (9080, 9443) to the ExposeEnricher so that routes get generated.
rohanKanojia added a commit to rohanKanojia/jkube that referenced this pull request Feb 25, 2020
+ Add a generator for Open Liberty that extends the java-exec generator. It defaults webPort to the Liberty default port (9080) and adds an environment variable for use by S2I if it detects a Liberty runnable jar.
+ Add Liberty's default web ports (9080, 9443) to the ExposeEnricher so that routes get generated.
rohanKanojia added a commit to rohanKanojia/jkube that referenced this pull request Mar 2, 2020
+ Add a generator for Open Liberty that extends the java-exec generator. It defaults webPort to the Liberty default port (9080) and adds an environment variable for use by S2I if it detects a Liberty runnable jar.
+ Add Liberty's default web ports (9080, 9443) to the ExposeEnricher so that routes get generated.
rohanKanojia added a commit to eclipse-jkube/jkube that referenced this pull request Mar 2, 2020
+ Add a generator for Open Liberty that extends the java-exec generator. It defaults webPort to the Liberty default port (9080) and adds an environment variable for use by S2I if it detects a Liberty runnable jar.
+ Add Liberty's default web ports (9080, 9443) to the ExposeEnricher so that routes get generated.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants