Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increasing the service name length to 63 to reflect the updated limits in kubernetes v1.4.0 #857

Merged
merged 1 commit into from Mar 13, 2017

Conversation

@codecov
Copy link

codecov bot commented Feb 27, 2017

Codecov Report

Merging #857 into master will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master     #857   +/-   ##
=========================================
  Coverage     18.16%   18.16%           
  Complexity      473      473           
=========================================
  Files           160      160           
  Lines          8279     8279           
  Branches       1484     1484           
=========================================
  Hits           1504     1504           
  Misses         6603     6603           
  Partials        172      172

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d907202...53c0eac. Read the comment docs.

@pldimitrov pldimitrov changed the title increasing the app name length to 63 to reflect the updated limits in kubernetes v1.4.0 increasing the service name length to 63 to reflect the updated limits in kubernetes v1.4.0 Feb 27, 2017
@pldimitrov
Copy link
Author

pldimitrov commented Mar 6, 2017

Hi there, we were having issues with the plugin truncating service names and I noticed this was fixed in Kubernetes v1.4.0-alpha.3 (kubernetes/kubernetes#29523) so it seems like there is no reason to keep the service names limited to 24 characters anymore.

@rhuss
Copy link
Contributor

rhuss commented Mar 13, 2017

Thanks ! looks good to me

[merge]

@fusesource-ci fusesource-ci merged commit 52c367b into fabric8io:master Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants