fabric-agent - Reading maven settings.xml may cause issue

[davsclaus]

There is some new code that reads m2/settings.xml to find proxy settings etc. But sometimes the CI servers cause it to fail with a -1 unknown type error.

Error Message

Container child1 failed to provision. Status:error - io.fabric8.common.util.MultiException: Error while downloading artifacts: Exception:io.fabric8.common.util.MultiException: Error while downloading artifacts:
 1: Error downloading mvn:io.fabric8/fabric8-karaf/1.1.0-SNAPSHOT/xml/features
 at io.fabric8.agent.utils.AgentUtils$ArtifactDownloader.await(AgentUtils.java:393)
 at io.fabric8.agent.utils.AgentUtils.loadRepositories(AgentUtils.java:234)
 at io.fabric8.agent.DeploymentAgent.doUpdate(DeploymentAgent.java:534)
 at io.fabric8.agent.DeploymentAgent$2.run(DeploymentAgent.java:298)
 at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
 at java.util.concurrent.FutureTask.run(FutureTask.java:262)
 at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
 at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
 at java.lang.Thread.run(Thread.java:744)
java.io.IOException: Error downloading mvn:io.fabric8/fabric8-karaf/1.1.0-SNAPSHOT/xml/features
 at io.fabric8.agent.download.AbstractDownloadTask.initIOException(AbstractDownloadTask.java:107)
 at io.fabric8.agent.download.AbstractDownloadTask.run(AbstractDownloadTask.java:93)
 at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
 at java.util.concurrent.FutureTask.run(FutureTask.java:262)
 at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
 at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
 at java.lang.Thread.run(Thread.java:744)
Caused by: java.lang.IllegalArgumentException: type: -1
 at org.apache.xerces.dom.DeferredDocumentImpl.getNodeObject(Unknown Source)
 at org.apache.xerces.dom.DeferredDocumentImpl.synchronizeChildren(Unknown Source)
 at org.apache.xerces.dom.DeferredElementImpl.synchronizeChildren(Unknown Source)
 at org.apache.xerces.dom.ParentNode.getChildNodes(Unknown Source)
 at io.fabric8.common.util.XmlUtils.getElement(XmlUtils.java:81)
 at io.fabric8.common.util.XmlUtils.getElements(XmlUtils.java:104)
 at io.fabric8.common.util.XmlUtils.getElements(XmlUtils.java:95)
 at io.fabric8.agent.mvn.MavenSettingsImpl.getProxySettings(MavenSettingsImpl.java:413)
 at io.fabric8.agent.mvn.MavenConfigurationImpl.enableProxy(MavenConfigurationImpl.java:292)
 at io.fabric8.agent.download.MavenDownloadTask.prepareInputStream(MavenDownloadTask.java:461)
 at io.fabric8.agent.download.MavenDownloadTask.getMetadata(MavenDownloadTask.java:243)
 at io.fabric8.agent.download.MavenDownloadTask.resolveSnapshotVersion(MavenDownloadTask.java:347)
 at io.fabric8.agent.download.MavenDownloadTask.doCollectPossibleDownloads(MavenDownloadTask.java:195)
 at io.fabric8.agent.download.MavenDownloadTask.collectPossibleDownloads(MavenDownloadTask.java:157)
 at io.fabric8.agent.download.MavenDownloadTask.download(MavenDownloadTask.java:89)
 at io.fabric8.agent.download.AbstractDownloadTask.run(AbstractDownloadTask.java:76)
 ... 5 more

Wonder if we can ignore these kind of error and keep the code continuing as before.

An example of test failure
http://174.129.32.31:8080/job/fabric8-pullreq/2384/testReport/junit/io.fabric8.itests.basic.mq/MQProfileTest/testMQCreateBasic/

[jstrachan]

think this is fixed now