Skip to content

Commit

Permalink
doc (kubernetes-client-api) : Add note about changed NO_PROXY behavio…
Browse files Browse the repository at this point in the history
…r with wildcards (#4418)

+ Add breaking change note in CHANGELOG in release v6.1.0
+ Add FAQ regarding changed NO_PROXY behavior

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
  • Loading branch information
rohanKanojia authored and manusa committed Jan 16, 2023
1 parent 3f6c1ff commit fe0edfd
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@ fix #4373: NO_PROXY should allow URIs with hyphens ("circleci-internal-outer-bui
- `io.fabric8.chaosmesh.v1alpha1.AwsChaos` => `io.fabric8.chaosmesh.v1alpha1.AWSChaos`
- `io.fabric8.chaosmesh.v1alpha1.IoChaos` => `io.fabric8.chaosmesh.v1alpha1.IOChaos`
- `io.fabric8.chaosmesh.v1alpha1.PodIoChaos` => `io.fabric8.chaosmesh.v1alpha1.PodIOChaos`
* Fix #4247: Proxy matching no longer supports having wildcard characters in `NO_PROXY`. The behavior has been changed to match [GNU WGet Spec](https://www.gnu.org/software/wget/manual/html_node/Proxies.html)

### 5.12.3 (2022-07-27)

Expand Down
17 changes: 17 additions & 0 deletions doc/FAQ.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,3 +102,20 @@ Once added KubernetesClient declarative services would be exposed automatically
@BeanInject
private KubernetesClient kubernetesClient
```

### Why am I getting Exception when using `*` in NO_PROXY ?

Starting Fabric8 Kubernetes Client v6.1.0, we've change NO_PROXY matching as simple as possible and not support any meta characters. It honors the [GNU WGet Spec](https://www.gnu.org/software/wget/manual/html_node/Proxies.html).

So instead of providing NO_PROXY like this:

(Unsupported) :x:
```java
NO_PROXY: localhost,127.0.0.1,*.google.com, *.github.com
```
we should provide it like this:

(Supported) :heavy_check_mark:
```java
NO_PROXY: localhost,127.0.0.1,.google.com,.github.com
```

0 comments on commit fe0edfd

Please sign in to comment.