Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KnativeResourceMappingsProvider uses wrong apiGroup #1838

Closed
iocanel opened this issue Oct 29, 2019 · 2 comments
Closed

KnativeResourceMappingsProvider uses wrong apiGroup #1838

iocanel opened this issue Oct 29, 2019 · 2 comments
Labels
status/never-stale

Comments

@iocanel
Copy link
Member

iocanel commented Oct 29, 2019

Uses knative.dev while it should be using serving.knative.dev etc.
@iocanel iocanel mentioned this issue Oct 29, 2019
Merged
iocanel added a commit to iocanel/kubernetes-client that referenced this issue Oct 29, 2019
@iocanel
fix (fabric8io#1838) Use correct apiGroup for knative serving and add…
d0311ee 
… missing

entries for messaging and eventing.
iocanel added a commit to iocanel/kubernetes-client that referenced this issue Oct 30, 2019
@iocanel
fix (fabric8io#1838) Use correct apiGroup for knative serving and add…
cd74f9e 
… missing

entries for messaging and eventing.
@stale
Copy link

stale bot commented Jan 27, 2020

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label Jan 27, 2020
@stale stale bot closed this as completed Feb 3, 2020
@rohanKanojia rohanKanojia reopened this Feb 3, 2020
@stale stale bot removed the status/stale label Feb 3, 2020
@stale stale bot removed the status/stale label Feb 3, 2020
@shawkins
Copy link
Contributor

Resolving as out-of-date as this has already been addressed. This sort of thing won't happen if we move forward with the jandex discovery, or if we just refactor the mapping provider to be based only on class - which is also part of #4024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/never-stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iocanel @shawkins @rohanKanojia