Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isReady() from internal package make it publicly available #2452

Closed
saparaj opened this issue Aug 31, 2020 · 2 comments · Fixed by #2495
Closed

isReady() from internal package make it publicly available #2452

saparaj opened this issue Aug 31, 2020 · 2 comments · Fixed by #2495
Assignees

Comments

@saparaj
Copy link

saparaj commented Aug 31, 2020

Hi Fabric8io Team,

I am currently using waitUntilReady() method which blocks the thread till resources are ready, instead of waiting I need to poll the status of resources, I can see isReady method is getting called in waitUntilReady() which is in internal package, is there any external/publicly available method present with the same implementation?

The response I got from @rohanKanojia on gitter that we can create wrapper method in utils for isReady() method - https://github.com/fabric8io/kubernetes-client/blob/master/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/utils/KubernetesResourceUtil.java

Creating this issue to track it.

Thanks,
Swarda

@rohanKanojia
Copy link
Member

This seems like an easy fix to me. Would you like to create a PR for this?

@rohanKanojia rohanKanojia self-assigned this Sep 17, 2020
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Sep 17, 2020
…a wrapper method in KubernetesResourceUtil
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Sep 17, 2020
…a wrapper method in KubernetesResourceUtil
@saparaj
Copy link
Author

saparaj commented Sep 18, 2020

Thank you @rohanKanojia, Sorry I missed your comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants