Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encapsulate finalizer validation #2628

Closed
metacosm opened this issue Nov 24, 2020 · 0 comments · Fixed by #2629
Closed

Encapsulate finalizer validation #2628

metacosm opened this issue Nov 24, 2020 · 0 comments · Fixed by #2629
Assignees
@metacosm
Labels
component/kubernetes-client Deals with the kubernetes-client enhancement
Milestone
5.0.0

Comments

@metacosm
Copy link
Collaborator

HasMetadata should encapsulate the details of how the finalizer validation is performed instead of relying on client code using the regular expression, which doesn't even encapsulate all the required rules.
@metacosm metacosm added enhancement component/kubernetes-client Deals with the kubernetes-client labels Nov 24, 2020
@metacosm metacosm self-assigned this Nov 24, 2020
@snowdrop-bot snowdrop-bot mentioned this issue Nov 24, 2020
Closed
metacosm added a commit to metacosm/kubernetes-client that referenced this issue Nov 24, 2020
@metacosm
fix: add isFinalizerValid to encapsulate validation logic
2d16e01 
Fixes fabric8io#2628
@metacosm metacosm mentioned this issue Nov 24, 2020
Merged
11 tasks
@snowdrop-bot snowdrop-bot mentioned this issue Nov 24, 2020
Closed
11 tasks
metacosm added a commit to halkyonio/java-operator-sdk that referenced this issue Nov 25, 2020
@metacosm
refactor: isolate finalizer validation until HasMetadata provides it
39dd757 
See fabric8io/kubernetes-client#2628
manusa pushed a commit to metacosm/kubernetes-client that referenced this issue Nov 26, 2020
@metacosm @manusa
fix: add isFinalizerValid to encapsulate validation logic
0e258e4 
Fixes fabric8io#2628
@manusa manusa added this to the 5.0.0 milestone Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metacosm metacosm

Labels
component/kubernetes-client Deals with the kubernetes-client enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

fix: add isFinalizerValid to encapsulate validation logic metacosm/kubernetes-client
2 participants
@metacosm @manusa