Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for v1 CertificateSigningRequest #2703

Closed
rohanKanojia opened this issue Jan 4, 2021 · 1 comment · Fixed by #2778
Closed

Add Support for v1 CertificateSigningRequest #2703

rohanKanojia opened this issue Jan 4, 2021 · 1 comment · Fixed by #2778
Assignees
@rohanKanojia
Labels
component/kubernetes-model Deals with the kubernetes-model enhancement
Milestone
5.1.0

Comments

@rohanKanojia
Copy link
Member

Kubernetes Certificate API has a new V1 version. We should add it to kubernetes-model-certificates

kubernetes-client/kubernetes-model-generator/kubernetes-model-certificates/cmd/generate/generate.go

Line 27 in 6a7a7e4

certificates "k8s.io/api/certificates/v1beta1"

@manusa manusa added this to the 5.1.0 milestone Jan 7, 2021
@manusa manusa added component/kubernetes-model Deals with the kubernetes-model enhancement labels Jan 7, 2021
@rohanKanojia rohanKanojia self-assigned this Feb 2, 2021
@rohanKanojia
Copy link
Member Author

v1 CertificateSigningRequest is now a part of kubernetes-model-certificates. We just need to add DSL support in KubernetesClient

rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Feb 2, 2021
@rohanKanojia
Fix fabric8io#2703 : Add support for certificates.k8s.io v1 and v1b…
d3994fe 
…eta1 API in KubernetesClient DSL

+ Added a new `client.certificates()` DSL to KubernetesClient
@rohanKanojia rohanKanojia mentioned this issue Feb 2, 2021
Merged
11 tasks
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Feb 2, 2021
@rohanKanojia
Fix fabric8io#2703 : Add support for certificates.k8s.io v1 and v1b…
1080d11 
…eta1 API in KubernetesClient DSL

+ Added a new `client.certificates()` DSL to KubernetesClient
+ Mark `client.certificateSigningRequests()` as `@Deprecated`
manusa pushed a commit that referenced this issue Feb 5, 2021
@rohanKanojia @manusa
Fix #2703 : Add support for certificates.k8s.io v1 and v1beta1 API …
9322468 
…in KubernetesClient DSL

+ Added a new `client.certificates()` DSL to KubernetesClient
+ Mark `client.certificateSigningRequests()` as `@Deprecated`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
component/kubernetes-model Deals with the kubernetes-model enhancement
Projects
None yet
Milestone
5.1.0
2 participants
@manusa @rohanKanojia