You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
setApiVersion and setKind have debug messages which are likely intended for scenarios where the methods are explicitly called - but when you are relying upon deserialization they are also called by jackson. For lots of objects this can dominate the debug log.
The text was updated successfully, but these errors were encountered:
Does it make sense to log anything at all in any context?
IMHO a warning might make sense because if these methods are explicitly called by developers, something should warn them that it won't have any effect.
However, seeing the current usage and approaches, what might make more sense is just to provide more specific JavaDoc with a warning about the NOOP implementation, and remove the log.
shawkins
added a commit
to shawkins/kubernetes-client
that referenced
this issue
Apr 29, 2021
setApiVersion and setKind have debug messages which are likely intended for scenarios where the methods are explicitly called - but when you are relying upon deserialization they are also called by jackson. For lots of objects this can dominate the debug log.
The text was updated successfully, but these errors were encountered: