Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug messages in CustomResource logged too often #3057

Closed
shawkins opened this issue Apr 28, 2021 · 2 comments
Closed

Debug messages in CustomResource logged too often #3057

shawkins opened this issue Apr 28, 2021 · 2 comments

Comments

@shawkins
Copy link
Contributor

setApiVersion and setKind have debug messages which are likely intended for scenarios where the methods are explicitly called - but when you are relying upon deserialization they are also called by jackson. For lots of objects this can dominate the debug log.

@manusa
Copy link
Member

manusa commented Apr 29, 2021

Relates to #2683, #2661

This was very lightly discussed in #2661.

Does it make sense to log anything at all in any context?
IMHO a warning might make sense because if these methods are explicitly called by developers, something should warn them that it won't have any effect.
However, seeing the current usage and approaches, what might make more sense is just to provide more specific JavaDoc with a warning about the NOOP implementation, and remove the log.

shawkins added a commit to shawkins/kubernetes-client that referenced this issue Apr 29, 2021
@shawkins
Copy link
Contributor Author

If you want to keep the log, consider #3059

I'm fine with removing it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants