-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
non-optimistic locking updateStatus #3066
Comments
Spawned #3067 to cover the related question on patching behavior. |
Looking at the go client there is both a applyStatus and an updateStatus. Apply is a PATCH, and update is a PUT. I think the resolution here would be to add a similar applyStatus method to fabric8. For consistency should fabric8 be using both the update and replace terms for a PUT call - that is should it be replaceStatus instead of updateStatus, or update(item) instead of replace(item)? |
this consolidated the base patch support logic to a single method, adds an applyStatus, and refines the patch(base, item) behavior when null
this consolidated the base patch support logic to a single method, adds an applyStatus, and refines the patch(base, item) behavior when null
With #3070 I'm proposing to add editStatus, patchStatus, and replaceStatus |
this consolidated the base patch support logic to a single method, adds an applyStatus, and refines the patch(base, item) behavior when null
this consolidated the base patch support logic to a single method, adds an applyStatus, and refines the patch(base, item) behavior when null
this consolidated the base patch support logic to a single method, adds an applyStatus, and refines the patch(base, item) behavior when null
I think that #3070 fixes this issue, status should be now modifiable in isolation of the rest of the resource, right? |
Yes, this fixed by #3070 |
this consolidated the base patch support logic to a single method, adds an applyStatus, and refines the patch(base, item) behavior when null
updateStatus is implemented as a PUT to /status, which requires the resource to have a resourceVersion specified.
Is there a safe alternative to implementing this with a patch or edit instead?
For example it seems like updateStatus could produce a json patch string and call the new patch(PatchContext patchContext, String patch) method.
This is related to operator-framework/java-operator-sdk#409
Related to this and based upon comments in #2166 #2701 - is there a general issue with the current patch(T item) and edit calls in that they compute the diff based upon the current item compared to the changed item - if there is a resourceVersion specified on the item, shouldn't the diff be generated against that base version instead?
The text was updated successfully, but these errors were encountered: