Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let CRDGenerator API clients decide what should be output and how #3366

Closed
metacosm opened this issue Aug 2, 2021 · 0 comments · Fixed by #3367
Closed

Let CRDGenerator API clients decide what should be output and how #3366

metacosm opened this issue Aug 2, 2021 · 0 comments · Fixed by #3367
Assignees
@metacosm
Labels
component/crd-generator Related to the CRD generator
Milestone
5.7.0

Comments

@metacosm
Copy link
Collaborator

metacosm commented Aug 2, 2021

The CRD generation process currently automatically outputs information that might not be interesting to clients of the API and/or might interfere with their own logging. It would be better to provide the currently output information as part of the detailedGenerate method result so that clients can decide what should be output and how.
@metacosm metacosm self-assigned this Aug 2, 2021
@metacosm metacosm added this to the 5.7.0 milestone Aug 2, 2021
metacosm added a commit that referenced this issue Aug 2, 2021
@metacosm
feat: let CRDGenerator clients handle output
a8f93f9 
This is meant so that clients of the CRD generation API can decide what
to output and how. Information that wasn't previously exposed is now
made available on CRDInfo for interested clients.

Fixes #3366
@metacosm metacosm mentioned this issue Aug 2, 2021
Merged
11 tasks
metacosm added a commit that referenced this issue Aug 2, 2021
@metacosm
feat: let CRDGenerator clients handle output
bfe6382 
This is meant so that clients of the CRD generation API can decide what
to output and how. Information that wasn't previously exposed is now
made available on CRDInfo for interested clients.

Fixes #3366
@snowdrop-bot snowdrop-bot mentioned this issue Aug 2, 2021
Closed
metacosm added a commit that referenced this issue Aug 2, 2021
@metacosm
feat: let CRDGenerator clients handle output
9431308 
This is meant so that clients of the CRD generation API can decide what
to output and how. Information that wasn't previously exposed is now
made available on CRDInfo for interested clients.

Note also that `CRDInfo.getVersion` has been deprecated in favor of
`getCrdSpecVersion` to clarify which version we're talking about: the
CRD spec, not the CRD version.

Fixes #3366
@manusa manusa added the component/crd-generator Related to the CRD generator label Aug 3, 2021
manusa pushed a commit that referenced this issue Aug 4, 2021
@metacosm @manusa
feat: let CRDGenerator clients handle output
00e9cf8 
This is meant so that clients of the CRD generation API can decide what
to output and how. Information that wasn't previously exposed is now
made available on CRDInfo for interested clients.

Note also that `CRDInfo.getVersion` has been deprecated in favor of
`getCrdSpecVersion` to clarify which version we're talking about: the
CRD spec, not the CRD version.

Fixes #3366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metacosm metacosm

Labels
component/crd-generator Related to the CRD generator
Projects
None yet
Milestone
5.7.0
Development

Successfully merging a pull request may close this issue.

feat: let CRDGenerator clients handle output fabric8io/kubernetes-client
2 participants
@metacosm @manusa