Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sorting from Template#getObjects #3628

Closed
manusa opened this issue Dec 2, 2021 · 0 comments
Closed

Remove sorting from Template#getObjects #3628

manusa opened this issue Dec 2, 2021 · 0 comments
Assignees
Milestone

Comments

@manusa
Copy link
Member

manusa commented Dec 2, 2021

Template sorts objects in when retrieved through the getter using HasMetadataComparator.

Originally posted by @shawkins in #3606 (comment)

@rohanKanojia @manusa this may be a silly question, but why is sorting required?

No idea, I guess that at some point the order on which the items was applied was important.
Traced it back to fabric8io/kubernetes-model@78ab3a6#diff-4a305396a3d2548c17df3329d5251eda2dca65c060f858588d99068cc7d205e9

If a reference can't be found, I'd say this behavior seems undesirable. Based upon HasMetadataComparator (which seems somewhat arbitrary) it look like a pretty print option that was added to KubernetesList and Template. Ideally it should optional or the user's responsibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants