Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pod.evict return and exception handling #3853

Closed
shawkins opened this issue Feb 14, 2022 · 4 comments · Fixed by #3919
Closed

Pod.evict return and exception handling #3853

shawkins opened this issue Feb 14, 2022 · 4 comments · Fixed by #3919
Assignees
@shawkins
Milestone
6.0.0

Comments

@shawkins
Copy link
Contributor

Is your enhancement related to a problem? Please describe

Pod.evict returns Boolean, but can only be two valued. The 429 is indistinguishable from a 404 - in most other api calls 404 would be an exception.

Describe the solution you'd like

It should return a boolean and throw an exception on a 404.

Describe alternatives you've considered

No response

Additional context

No response
@shawkins shawkins added this to the 6.0.0 milestone Feb 14, 2022
manusa pushed a commit to shawkins/kubernetes-client that referenced this issue Feb 22, 2022
@shawkins @manusa
fix fabric8io#3853 addressing dsl.base and extended.run
82d6c06 
fixing extension references
manusa pushed a commit to shawkins/kubernetes-client that referenced this issue Feb 22, 2022
@shawkins @manusa
fix fabric8io#3853 addressing informers and utils
f914544
manusa pushed a commit to shawkins/kubernetes-client that referenced this issue Feb 22, 2022
@shawkins @manusa
fix fabric8io#3853 addressing dsl.base and extended.run
d8889bf 
fixing extension references
manusa pushed a commit to shawkins/kubernetes-client that referenced this issue Feb 22, 2022
@shawkins @manusa
fix fabric8io#3853 addressing informers and utils
3f0769e
@manusa manusa closed this as completed in 43f36d2 Feb 22, 2022
manusa pushed a commit that referenced this issue Feb 22, 2022
@shawkins @manusa
fix #3853 addressing informers and utils
496b7ed
@manusa
Copy link
Member

manusa commented Feb 22, 2022

I don't think #3844 takes care of this issue

@manusa manusa reopened this Feb 22, 2022
@shawkins
Copy link
Contributor Author

I don't think #3844 takes care of this issue

No, this issue hasn't been worked yet.

@shawkins
Copy link
Contributor Author

Other places in the api returning Boolean should likewise be changed to boolean - unless for some reason three valued logic is expected.

@shawkins shawkins self-assigned this Feb 25, 2022
@shawkins
Copy link
Contributor Author

This will need to wait until #3845 to reduce conflicts.

shawkins added a commit to shawkins/kubernetes-client that referenced this issue Mar 2, 2022
@shawkins
fix fabric8io#3853: replacing Boolean with boolean and throwing a 404…
f6fd473 
… from evict
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Mar 2, 2022
@shawkins
fix fabric8io#3853: replacing Boolean with boolean and throwing a 404…
b64cd7e 
… from evict
@shawkins shawkins linked a pull request Mar 2, 2022 that will close this issue
fix #3853: replacing Boolean with boolean and throwing a 404 from evict #3919
Merged
11 tasks
manusa pushed a commit that referenced this issue Mar 7, 2022
@shawkins @manusa
fix #3853: replacing Boolean with boolean and throwing a 404 from evict
39ce8be
@shawkins shawkins mentioned this issue Mar 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawkins shawkins

Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

fix #3853: replacing Boolean with boolean and throwing a 404 from evict shawkins/kubernetes-client
2 participants
@manusa @shawkins