Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

withResourceVersion off of collection problems with waitable #4081

Closed
shawkins opened this issue Apr 21, 2022 · 0 comments · Fixed by #4083
Closed

withResourceVersion off of collection problems with waitable #4081

shawkins opened this issue Apr 21, 2022 · 0 comments · Fixed by #4083
Assignees
@shawkins
Milestone
6.0.0

Comments

@shawkins
Copy link
Contributor

waitable for mixedoperations is currently only implemented for a single resource context. However it is available off of a collection context via:

client.configMaps().withResourceVersion("x").waitUntilCondition...

Either this should be disallowed, or the implementation should apply the condition / readiness to each item - that is the behavior of those methods when called from a resourceList - client.resourceList(...).waitUntilCondition(...)
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Apr 21, 2022
@shawkins
fix fabric8io#4081 fabric8io#4082: correcting/removing versionable
cfd5dc9 
also improving informOnCondition
@shawkins shawkins mentioned this issue Apr 21, 2022
Merged
11 tasks
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Apr 21, 2022
@shawkins
fix fabric8io#4081 fabric8io#4082: correcting/removing versionable
7450c48 
also improving informOnCondition
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Apr 21, 2022
@shawkins
fix fabric8io#4081 fabric8io#4082: correcting/removing versionable
e49929a 
also improving informOnCondition
@manusa manusa added this to the 6.0.0 milestone Apr 26, 2022
manusa pushed a commit to shawkins/kubernetes-client that referenced this issue Apr 28, 2022
@shawkins @manusa
fix fabric8io#4081 fabric8io#4082: correcting/removing versionable
0f3c8f8 
also improving informOnCondition
manusa pushed a commit that referenced this issue Apr 28, 2022
@shawkins @manusa
fix #4081 #4082: correcting/removing versionable
03ec3b1 
also improving informOnCondition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawkins shawkins

Labels
None yet
Projects
None yet
Milestone
6.0.0
2 participants
@manusa @shawkins