Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support subresources, e.g. scale, deploymentrollback, etc #417

Closed
jimmidyson opened this issue May 25, 2016 · 7 comments · Fixed by #1920
Closed

Support subresources, e.g. scale, deploymentrollback, etc #417

jimmidyson opened this issue May 25, 2016 · 7 comments · Fixed by #1920
Assignees
Projects

Comments

@jimmidyson
Copy link
Contributor

Certain operations are applicable via subresources rather than updating the resource. We need a general way to support this as it's important for authorization policies that allow updating via subresources but not the resource itself.

@xguerin
Copy link

xguerin commented Feb 16, 2019

Has there been any updates on that topic?

@stale
Copy link

stale bot commented Aug 6, 2019

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label Aug 6, 2019
@stale stale bot closed this as completed Aug 13, 2019
@XciD
Copy link

XciD commented Sep 11, 2019

Any update ?

@rohanKanojia rohanKanojia reopened this Sep 11, 2019
@stale stale bot removed the status/stale label Sep 11, 2019
@rohanKanojia
Copy link
Member

@XciD : Unfortunately I haven't been able to find time to fix this. Could you please create a PR to support these if you have bandwidth?

@stale
Copy link

stale bot commented Dec 10, 2019

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label Dec 10, 2019
@jglick
Copy link
Contributor

jglick commented Dec 10, 2019

Found this by noticing that the scale method, despite seeming similar to the kubectl command, requires patch rather than the more limited put/scale in RBAC, so is not using the designated API.

@stale stale bot removed the status/stale label Dec 10, 2019
@rohanKanojia rohanKanojia self-assigned this Dec 11, 2019
@rohanKanojia
Copy link
Member

rohanKanojia commented Dec 11, 2019

@jglick : Thanks for pointing this out. I also think we should use designated api. So for starting what resources shall we consider adding support in model/DSL? I have these in mind:

  • DeploymentRollback
  • Scale
  • DeleteOptions
  • CreateOptions
  • GetOptions
  • ListOptions
  • PatchOptions

rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Dec 27, 2019
+ Changed extensions/Scale to autoscaling/Scale
+ Added tests
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Dec 30, 2019
+ Changed extensions/Scale to autoscaling/Scale
+ Added tests
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Jan 2, 2020
+ Changed extensions/Scale to autoscaling/Scale
+ Added tests
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Jan 7, 2020
+ Changed extensions/Scale to autoscaling/Scale
+ Added tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Project FKC
  
Awaiting triage
Development

Successfully merging a pull request may close this issue.

5 participants