LeaderElection leader transitions

[shawkins]

LeaderTransitions is resetting on a change of leadership, and incrementing while holding the lock. I think this should instead be to increment on a change and to leave the value alone will renewing.

[manusa]

The leader election record leaderTransitions field should only increment after a change of leadership.

Related client-go code in leaderelection.go:

	// 3. We're going to try to update. The leaderElectionRecord is set to it's default
	// here. Let's correct it before updating.
	if le.IsLeader() {
		leaderElectionRecord.AcquireTime = oldLeaderElectionRecord.AcquireTime
		leaderElectionRecord.LeaderTransitions = oldLeaderElectionRecord.LeaderTransitions
	} else {
		leaderElectionRecord.LeaderTransitions = oldLeaderElectionRecord.LeaderTransitions + 1
	}

The following code needs an update (+test):

kubernetes-client/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/extended/leaderelection/LeaderElector.java

Lines 169 to 174 in b860309

	final LeaderElectionRecord newLeaderElectionRecord = new LeaderElectionRecord(
	lock.identity(),
	leaderElectionConfig.getLeaseDuration(),
	isLeader ? oldLeaderElectionRecord.getAcquireTime() : now,
	now,
	isLeader ? (oldLeaderElectionRecord.getLeaderTransitions() + 1) : 0);

[shawkins]

Yes the pr has https://github.com/fabric8io/kubernetes-client/pull/4322/files#diff-46850c90b4117631201b452d6d1b2bc5cc7de7270ccda4d69e5ac2c829938419R200