-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
public class GatewayClass implements Namespaced interface, but the scope of GatewayClass crd is Cluster #4654
Comments
Unfortunately this requires an update to
I think we should do something similar to our integration plural check, PluralizeIT, and check the generated metadata against whatever is available in the cluster for mismatches in the namespacing. @chenylh are these changes you'd be interested in making? |
Can you elaborate on how to verify these inconsistent errors? I need to assess whether there is any conflict with my work currently in team progress. @steven Hawkins
…---- Replied Message ----
| From | Steven ***@***.***> |
| Date | 12/10/2022 22:07 |
| To | ***@***.***> |
| Cc | ***@***.***>***@***.***> |
| Subject | Re: [fabric8io/kubernetes-client] public class GatewayClass implements Namespaced interface, but the scope of GatewayClass crd is Cluster (Issue #4654) |
Unfortunately this requires an update to https://github.com/fabric8io/kubernetes-client/blob/d418273f932053c9e9a03f723172824ed5ec42fd/kubernetes-model-generator/pkg/schemagen/generate.go#L559 and a regeneration of the model.
I think we should do something similar to our integration plural check, PluralizeIT, and check the generated metadata against whatever is available in the cluster for mismatches in the namespacing.
@chenylh are these changes you'd be interested in making?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@chenylh I just locally tried against minikube and with what is installed by default there are no namespace metadata errors, so don't worry about adding any additional validation. The scope of fix is to update the list of non namespaced entities, then run kubernetes-model-generator/generateModels.sh kubernetes-model-gateway, then check in all the modifications. |
@shawkins Thank you. Which version is this added to? We are in agile iteration |
@chenylh : Are you working on this? Do you mind if i pick this up? |
… Namespaced interface (fabric8io#4654) GatewayClass is a cluster scoped resource. It should not implement Namespaced interface. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
… Namespaced interface (#4654) GatewayClass is a cluster scoped resource. It should not implement Namespaced interface. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Describe the bug
Fabric8 Kubernetes Client version
6.2.0
Steps to reproduce
Expected behavior
public class GatewayClass implements Namespaced interface, but the scope of GatewayClass crd is Cluster
![image](https://user-images.githubusercontent.com/20794673/206827051-d68b4964-2cfa-4862-8a47-e58e8fd2008a.png)
![image](https://user-images.githubusercontent.com/20794673/206827050-3eedd121-9780-49ab-924d-9e3acf78d7de.png)
Runtime
Kubernetes (vanilla)
Kubernetes API Server version
other (please specify in additional context)
Environment
macOS
Fabric8 Kubernetes Client Logs
Additional context
No response
The text was updated successfully, but these errors were encountered: