Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO_PROXY rule with CIDR containing a bit suffix <10 appears to be ignored in the fabric client #4832

Closed
domwood opened this issue Feb 5, 2023 · 1 comment · Fixed by #4833
Assignees
Milestone

Comments

@domwood
Copy link
Contributor

domwood commented Feb 5, 2023

Describe the bug

Hi, I've been looking into an issue using the fabric client in a kubernetes cluster, where a NO_PROXY config rule including 10.0.0.0/8, appeared to be ignored in the client.

I think after looking at regex in the HttpClientUtils, it currently has no match for a single digit bit suffix. Adding a test example with cidr bit suffix <10 to the existing tests, seems to confirm this.

I should hopefully be able to raise a PR for this shortly.

Fabric8 Kubernetes Client version

5.10.2

Steps to reproduce

Configure a kubernetes client with NO_PROXY=10.0.0.0/8 and a HTTPS_PROXY=http://someproxy:433

Expected behavior

Expected: Any connections to ip addresses in the 10.0.0.0/8 range don't use the https proxy configured.

Actual: Connections to ips in the 10.0.0.0/8 range eg 10.0.100.1 are proxyied via the configured https proxy.

Runtime

Kubernetes (vanilla)

Kubernetes API Server version

1.25.3@latest

Environment

Linux

Fabric8 Kubernetes Client Logs

No response

Additional context

No response

domwood added a commit to domwood/kubernetes-client that referenced this issue Feb 5, 2023
@domwood
Copy link
Contributor Author

domwood commented Feb 5, 2023

I've submitted a PR, though i've not submitted one like this before. So let me know what further things I may need to do.

@manusa manusa added this to the 6.5.0 milestone Feb 9, 2023
manusa pushed a commit to domwood/kubernetes-client that referenced this issue Feb 9, 2023
manusa pushed a commit that referenced this issue Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants