Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial resourceVersion if initialState is used #4888

Closed
shawkins opened this issue Feb 16, 2023 · 0 comments · Fixed by #4944
Closed

Initial resourceVersion if initialState is used #4888

shawkins opened this issue Feb 16, 2023 · 0 comments · Fixed by #4944
Assignees
Labels
Milestone

Comments

@shawkins
Copy link
Contributor

The change to allow an initial cached listing for informers does not take into account the possibility of using initialState - since initialState is being specified without the last known resource version there's a chance that we're listing from before the initial state. This can lead to some undesirable events until things are caught up. Rather than trying to make the user track the last resource version, which may also require some additional locking to be done in a foolproof way, we should just use the latest listing instead.

@shawkins shawkins self-assigned this Feb 22, 2023
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Mar 2, 2023
manusa pushed a commit to shawkins/kubernetes-client that referenced this issue Mar 9, 2023
@manusa manusa added the bug label Mar 9, 2023
@manusa manusa added this to the 6.5.0 milestone Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants