Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KubernetesResourceUtil issues #5220

Closed
shawkins opened this issue Jun 7, 2023 · 4 comments · Fixed by #5435
Closed

KubernetesResourceUtil issues #5220

shawkins opened this issue Jun 7, 2023 · 4 comments · Fixed by #5435
Assignees
Milestone

Comments

@shawkins
Copy link
Contributor

shawkins commented Jun 7, 2023

The KubernetesResourceUtil methods related to resource names, labels, and annotations are not sufficiently documented or in some cases wrong. Resources names may be up to 253 characters, not just 63. Annotation and label keys name portion is limited to 63 chars, but they may contain a / separated prefix and with its own restrictions and the total character may be up to 253 characters long.
Annotation values are not restricted.

@manusa
Copy link
Member

manusa commented Jun 7, 2023

Is it possible that these restrictions have changed in recent (mind the wording, meaning 1.14 or earlier) Kubernetes releases?

@shawkins
Copy link
Contributor Author

shawkins commented Jun 8, 2023

Is it possible that these restrictions have changed in recent (mind the wording, meaning 1.14 or earlier)?

None of what's mentioned in the description would be very recent, but yes it's entirely possible that the util methods were more applicable quite a long time ago. At this point I don't see a need to separate out rules by version, we'll start with just bringing things up-to-date and expanding the javadocs were needed.

@manusa
Copy link
Member

manusa commented Jun 8, 2023

At this point I don't see a need to separate out rules by version

Neither do I. I was just curious about why were these rules implemented in the first place with wrong assumptions. The project's age seems to be taking a toll in some of our most foundational utilities. We (my team) might need to spend some time thoroughly reviewing those.

@stale
Copy link

stale bot commented Sep 7, 2023

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label Sep 7, 2023
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Sep 8, 2023
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Sep 8, 2023
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Sep 8, 2023
@manusa manusa added this to the 6.9.0 milestone Sep 18, 2023
manusa pushed a commit to shawkins/kubernetes-client that referenced this issue Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants