Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenshiftClient scale deploymentConfig Error #5236

Closed
cgcgccg opened this issue Jun 13, 2023 · 8 comments · Fixed by #5240
Closed

OpenshiftClient scale deploymentConfig Error #5236

cgcgccg opened this issue Jun 13, 2023 · 8 comments · Fixed by #5240
Assignees
Labels
Milestone

Comments

@cgcgccg
Copy link

cgcgccg commented Jun 13, 2023

Describe the bug

When I use openshift-client v6.7.1 to scale openshift deploymentConfig like below:
image

It will return error like this:
image

Fabric8 Kubernetes Client version

6.7.1

Steps to reproduce

Init openshift client
then use scale func
will return this error

Expected behavior

openshift client can scale deploymentConfig normal

Runtime

OpenShift

Kubernetes API Server version

1.25.3@latest

Environment

Windows, Linux

Fabric8 Kubernetes Client Logs

No response

Additional context

No response

@manusa
Copy link
Member

manusa commented Jun 13, 2023

We changed the way we scale resources to use the scale subresource. Maybe the OpenShift cluster is not supporting this operation. Could you share your cluster details (version, and so on).

/cc @shawkins

@sunix sunix added bug and removed bug labels Jun 13, 2023
@cgcgccg
Copy link
Author

cgcgccg commented Jun 13, 2023

We changed the way we scale resources to use the scale subresource. Maybe the OpenShift cluster is not supporting this operation. Could you share your cluster details (version, and so on).

/cc @shawkins

Hi, this is the version info:
Openshift version : 4.10
and
image

@shawkins
Copy link
Contributor

Yes more than likely DeploymetConfigs don't support v1 scale. We have overriden support for jobs and v1beta1 resources that will likely be applicable here.

@sunix sunix added Waiting on feedback Issues that require feedback from User/Other community members and removed Waiting on feedback Issues that require feedback from User/Other community members labels Jun 13, 2023
@manusa manusa added the bug label Jun 13, 2023
@shawkins
Copy link
Contributor

Sure enough:

{"kind":"Scale","apiVersion":"extensions/v1beta1", ...

Supprising that it's still using the deprecated api.

@cgcgccg
Copy link
Author

cgcgccg commented Jun 13, 2023

Sure enough:

{"kind":"Scale","apiVersion":"extensions/v1beta1", ...

Supprising that it's still using the deprecated api.

Thanks shawkins. So that's mean I should config my openshift-client apiVersion is v1beta1, is right?

@shawkins
Copy link
Contributor

So that's mean I should config my openshift-client apiVersion is v1beta1, is right?

No, it means that /scale on a DeploymentConfig resource understands v1beta1 scale, not v1.

I guess they haven't committed to addressing this upstream: https://bugzilla.redhat.com/show_bug.cgi?id=1931897 https://issues.redhat.com/browse/OCPBUGS-865

@cgcgccg
Copy link
Author

cgcgccg commented Jun 13, 2023

I understand. Thanks.

shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 13, 2023
@shawkins shawkins self-assigned this Jun 13, 2023
@manusa
Copy link
Member

manusa commented Jun 14, 2023

So that's mean I should config my openshift-client apiVersion is v1beta1, is right?

We'll probably release a 6.7 patch to address this and other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants