Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not repeatly create Config in exec #1081

Merged
merged 1 commit into from
May 25, 2018
Merged

Do not repeatly create Config in exec #1081

merged 1 commit into from
May 25, 2018

Conversation

skyline75489
Copy link
Contributor

@skyline75489 skyline75489 commented May 24, 2018

This fixes #1082

@oscerd
Copy link
Member

oscerd commented May 24, 2018

Can you please create an issue for this and add a line in CHANGELOG?

@oscerd
Copy link
Member

oscerd commented May 24, 2018

ok to test

@oscerd oscerd closed this May 24, 2018
@oscerd oscerd reopened this May 24, 2018
@oscerd
Copy link
Member

oscerd commented May 24, 2018

ok to test

@skyline75489
Copy link
Contributor Author

Sure. I get the CHANGELOG part. But why is an issue needed?

@oscerd
Copy link
Member

oscerd commented May 24, 2018

To track what you're doing. This project need to track any change/update we do, because in the past we broke things also for minor stuff like this.

@skyline75489
Copy link
Contributor Author

I see. The issue is here #1082 .

@oscerd
Copy link
Member

oscerd commented May 24, 2018

Thanks a lot :-)

@piyush-garg
Copy link
Contributor

Please update the PR with the changes in CHANGELOG.md because that is the file we track 😃

@skyline75489
Copy link
Contributor Author

Done.

@skyline75489
Copy link
Contributor Author

Man these tests are utterly time consuming...

@piyush-garg
Copy link
Contributor

Sorry to say, but you need to squash the commits into one also. We have complete guidelines here https://github.com/fabric8io/kubernetes-client/blob/master/CONTRIBUTING.md

@skyline75489
Copy link
Contributor Author

The regression failure is caused by timeout. Doesn't seem to relate to this PR.

@oscerd
Copy link
Member

oscerd commented May 25, 2018

Looks good.

@oscerd
Copy link
Member

oscerd commented May 25, 2018

[merge]

@fusesource-ci fusesource-ci merged commit 5752431 into fabric8io:master May 25, 2018
@skyline75489
Copy link
Contributor Author

Thanks everyone. We would love to see this be shipped soon.

@skyline75489 skyline75489 deleted the patch-2 branch May 25, 2018 08:30
@piyush-garg
Copy link
Contributor

Hey @skyline75489 Kubernetes Client 3.2.0 released which have this fix

@skyline75489
Copy link
Contributor Author

Thanks for the heads up 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perf: exec in PodOperationsImpl repeatly creates Config instance
5 participants