Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PersistentVolumeTest added #1570

Merged
merged 1 commit into from Jul 4, 2019
Merged

PersistentVolumeTest added #1570

merged 1 commit into from Jul 4, 2019

Conversation

kunal-kushwaha
Copy link
Contributor

Fixes #1381
Test coverage provided for PersistentVolume.

@centos-ci
Copy link

Can one of the admins verify this patch?

@rohanKanojia
Copy link
Member

ok to test

rohanKanojia
rohanKanojia reviewed Jun 10, 2019
View reviewed changes
kubernetes-tests/src/test/java/io/fabric8/kubernetes/client/mock/PersistentVolumeTest.java Outdated
import java.util.Collections;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused import

rohanKanojia
rohanKanojia reviewed Jun 10, 2019
View reviewed changes
Copy link
Member

@rohanKanojia rohanKanojia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment otherwise looks good

@kunal-kushwaha kunal-kushwaha force-pushed the PersistentVolumeTest branch 2 times, most recently from e0e4e40 to bcd8e0a Compare June 10, 2019 08:26
@rohanKanojia rohanKanojia added the changelog missing A line to changelog.md regarding the change is not added label Jun 13, 2019
@rohanKanojia rohanKanojia added gsoc candidate for GSoC and removed changelog missing A line to changelog.md regarding the change is not added labels Jun 14, 2019
@rohanKanojia
Copy link
Member

Thanks 👍

@rohanKanojia rohanKanojia merged commit 58d827b into fabric8io:master Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia left review comments

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
gsoc candidate for GSoC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test coverage missing for multiple resources
4 participants
@kunal-kushwaha @centos-ci @rohanKanojia @oscerd