HorizontalPodAutoscalerTest added #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
oscerd
approved these changes
Jun 13, 2019
|
ok to test |
rohanKanojia
reviewed
Jul 4, 2019
| .endScaleTargetRef() | ||
| .withMinReplicas(1) | ||
| .withMaxReplicas(10) | ||
| .addToMetrics(new io.fabric8.kubernetes.api.model.MetricSpecBuilder() |
There was a problem hiding this comment.
You need to modify it since #1590 has been merged and HPA's spec has changed a bit. Rebase this branch with master and rebuild, you would be able to see errors.
There was a problem hiding this comment.
@rohanKanojia: Requested changes made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1381
Test coverage provided for HorizontalPodAutoscaler.