feat(openshift): Support OpenShift 4.x API Groups. Fixes #1631 #1644
Conversation
|
ok to test |
| @@ -1,7 +1,7 @@ | |||
|
|
|||
| { | |||
| "kind": "Template", | |||
| "apiVersion": "v1", | |||
| "apiVersion": "template.openshift.io/v1", | |||
There was a problem hiding this comment.
@rohanKanojia @iocanel I need your expertise here: with this change, all templates must have the apiVersion set to template.openshift.io/v1, which may break existing functionality when reading template files set to v1. Any suggestions or should we let it throw an error indicating that the template needs to be fixed?
There was a problem hiding this comment.
Not sure but we can try adding notFoundTransformation entries in BackwardsCompatibilityInterceptor. I think this new apiVersion compatible with openshift 3.11 and 3.10 ? I think maybe we can dump v1 apiVersion users.....
| } catch (MalformedURLException e) { | ||
| throw KubernetesClientException.launderThrowable(e); | ||
| OpenShiftConfig config = OpenShiftConfig.wrap(context.getConfig()); | ||
| OpenShiftClient oc = new DefaultOpenShiftClient(context.getClient(), config); |
There was a problem hiding this comment.
When is this client closed?
rohanKanojia
force-pushed
the
os4
branch
2 times, most recently
from
c9ad8ef
to
cea79ce
Compare
|
I can confirm that this PR allows kubernetes-client to work in OS4. @rohanKanojia wanna merge it? |
|
[merge] |
This PR aims to support OpenShift 4.x endpoints Fix #1631