fixes portforwarding when there are more services with the same name in multiple namespaces #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in multiple namespaces
|
Can one of the admins verify this patch? |
|
ok to test |
oscerd
approved these changes
Aug 21, 2019
rohanKanojia
approved these changes
Aug 21, 2019
|
@BJMg : Could you please add a line to CHANGELOG regarding this? |
Thanks for accepting. It is done. |
|
@BJMg: There is a minor conflict, Could you please resolve it? I think we are good to merge after that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered an incorrect port forwarding (on service) when I had more than one namespace. In each namespace there were services with the same name. When I called portForward on service it randomly chose one of these services instead of the service with current namespace.
This pull request should remedy this behaviour.