Fix generation of resource handlers for OpenShift #1758
Conversation
|
Can one of the admins verify this patch? |
|
ok to test |
There was a problem hiding this comment.
@Vlatombe : Thanks for your PR. Could you please add the following:
- a small test validating the desired change
- a line to changelog about the change.
|
@rohanKanojia done |
| @@ -0,0 +1,66 @@ | |||
| package io.fabric8.openshift.client; | |||
|
|
|||
There was a problem hiding this comment.
Could you please add a license header here? This command would add it automatically:
mvn -N license:format
|
@rohanKanojia Done. |
|
retest this please |
| import io.fabric8.openshift.api.model.v4_0.OAuthClient; | ||
| import io.fabric8.openshift.api.model.v4_0.PolicyBinding; | ||
| import io.fabric8.openshift.api.model.v4_0.Project; | ||
| import io.fabric8.openshift.api.model.v4_0.RoleBinding; |
There was a problem hiding this comment.
Are you sure about this? I don't see any changes done in model with respect to this change. Could you please elaborate intention of having separate model for 4.0 openshift?
There was a problem hiding this comment.
@Vlatombe : I didn't see closely but build seems to be failing, Could you please fix it whenever you get time?
|
@rohanKanojia Fixed. I guess I got confused because these imports showed up in the classpath in IDEA but I missed that it was not available in |
|
@Vlatombe : Could you please update CHANGELOG also? we released 4.5.2 last weekend. |
|
We are good to merge this then 😄 |
|
@rohanKanojia You should consider using Release Drafter for changelog, it's really good. Under the @jenkinsci organization we've been using it for a while |
|
@Vlatombe It looks good to me. The only thing I would check, is that the changes done in the velocity template are algined with the rest of the modules. Its really handy if these variables are named the same across all templates, or we are going to have regressions next time we copy/paste something between them. |
|
@iocanel yes, I aligned the variable names with the corresponding kubernetes templates. |
Broken since 25da8ca