Respect the termination grace period from the Kubernetes resource as a default value #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a default value Signed-off-by: Jakub Scholz <www@scholzj.com>
|
Can one of the admins verify this patch? |
Merged
|
ok to test |
rohanKanojia
approved these changes
Oct 28, 2019
rohanKanojia
approved these changes
Nov 1, 2019
|
[merge] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1827, this PR sets the default grace period to
-1seconds as default. That should make the client not specify any grace period when deleting resources and this respect the grace period configured in the resource it self (e.g.terminationGracePeriodfield in PodSpec) or the Kubernetes default which is IMHO the most natural default behavior. When you test it for example with Pod, you should see that:withGracePeriod(...), the value from client is used.