Knative Generator Rewrite #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
Fabian-K
force-pushed
the
knative-generator-update
branch
from
6bb8cd1
to
f629b9c
Compare
oscerd
approved these changes
Apr 23, 2020
|
Hey, thanks for already looking into this! I´d suggest pausing this for now, I´d rebase it on top of #2160 |
Fabian-K
force-pushed
the
knative-generator-update
branch
from
f629b9c
to
3b8b55e
Compare
…de proper scoping (namespaced vs cluster-wide) for all parts using the rewritten go generator. Changes: - go configuration requires scoping definition for all CRDs - marker interface 'Namespaced' added - go generator adds the marker interface to all Namespaced CRDs - during the generation of the *OperationsImpl, the marker interface is used to detect the proper scoping. This fixes fabric8io#2193
rohanKanojia
reviewed
May 6, 2020
| // no other types need to be defined as they are auto discovered | ||
| crdLists := []reflect.Type{ | ||
|
|
||
| // serving v1 |
There was a problem hiding this comment.
Umm, why have you removed all resources from duck v1beta1. Are they not part of Knative model?
There was a problem hiding this comment.
2 things:
- all types that are only used internally are auto-discovered by the generator. Only CRDs need to be passed in as a starting point.
- AFAIK everything related to duck is not a CRD exposed by knative. Instead that is somehow used internally for duck typing. I might be wrong on this, do you have other information?
There was a problem hiding this comment.
Umm, I don't have much idea about Knative. I think it's okay if duck classes were not exposed earlier. I was just concerned if we could break something by dropping something that was present earlier.
Fabian-K
force-pushed
the
knative-generator-update
branch
from
3b8b55e
to
b1efad1
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
manusa
approved these changes
May 8, 2020
rohanKanojia
approved these changes
May 8, 2020
|
[merge] |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[knative]
[tekton]
[common]
As always, I´m looking forward to feedback!
Thanks,
Fabian