Fix #2311: Add Support for creating bootstrap project template #2376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Jul 29, 2020
rohanKanojia
force-pushed
the
pr/issue2311
branch
2 times, most recently
from
1ab246f
to
5a057ef
Compare
|
retest this please |
rohanKanojia
force-pushed
the
pr/issue2311
branch
from
5a057ef
to
aa5e530
Compare
manusa
reviewed
Aug 10, 2020
...ift-client/src/main/java/io/fabric8/openshift/client/dsl/internal/ProjectOperationsImpl.java
Outdated
Show resolved
Hide resolved
manusa
reviewed
Aug 10, 2020
...ift-client/src/main/java/io/fabric8/openshift/client/dsl/internal/ProjectOperationsImpl.java
Outdated
Show resolved
Hide resolved
manusa
reviewed
Aug 10, 2020
| .build(); | ||
| } | ||
|
|
||
| private List<HasMetadata> getNewProjectRoleBindings(String name, String adminUser) { |
There was a problem hiding this comment.
nit: same as https://github.com/fabric8io/kubernetes-client/pull/2376/files#r467693276, probably initRoleBinding is more clear
manusa
reviewed
Aug 10, 2020
kubernetes-tests/src/test/java/io/fabric8/openshift/client/server/mock/ProjectTest.java
Outdated
Show resolved
Hide resolved
rohanKanojia
force-pushed
the
pr/issue2311
branch
from
aa5e530
to
b6a3eed
Compare
manusa
approved these changes
Aug 10, 2020
rohanKanojia
force-pushed
the
pr/issue2311
branch
from
b6a3eed
to
89d55f2
Compare
Just like `oc adm create-bootstrap-project-template` generates a template yaml for project request resources to be created; OpenShiftClient should be able to generate + Apply resources based upon project request name, description, display name, requesting user and admin user. It should create the following resources: - Project (actual project to be created) - RoleBinding system:deployers - RoleBinding system:image-builders - RoleBinding system:image-pullers - RoleBinding admin
rohanKanojia
force-pushed
the
pr/issue2311
branch
from
89d55f2
to
46efaf5
Compare
|
SonarCloud Quality Gate failed.
|
|
[merge] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2311
Just like
oc adm create-bootstrap-project-templategenerates a template yaml forproject request resources to be created; OpenShiftClient should be able to
generate + Apply resources based upon project request name, description, display name,
requesting user and admin user. It should create the following resources:
Description
Type of change
test, version modification, documentation, etc.)
Checklist